microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-07 05:41:22 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Allow template string with no substitutions to be used as a string literal type (#18452)

Browse Source
This commit is contained in:
Andy 2017-09-14 11:19:54 -07:00 committed by GitHub
parent 6e512a495f
commit e91af7d30d
7 changed files with 24 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/factory.ts
View File

@ -773,13 +773,13 @@ namespace ts {
: node;
}
export function createLiteralTypeNode(literal: Expression) {
export function createLiteralTypeNode(literal: LiteralTypeNode["literal"]) {
const node = createSynthesizedNode(SyntaxKind.LiteralType) as LiteralTypeNode;
node.literal = literal;
return node;
}
export function updateLiteralTypeNode(node: LiteralTypeNode, literal: Expression) {
export function updateLiteralTypeNode(node: LiteralTypeNode, literal: LiteralTypeNode["literal"]) {
return node.literal !== literal
? updateNode(createLiteralTypeNode(literal), node)
: node;

14
src/compiler/parser.ts
View File

@ -2621,16 +2621,9 @@ namespace ts {
unaryMinusExpression.operator = SyntaxKind.MinusToken;
nextToken();
}
let expression: UnaryExpression;
switch (token()) {
case SyntaxKind.StringLiteral:
case SyntaxKind.NumericLiteral:
expression = parseLiteralLikeNode(token()) as LiteralExpression;
break;
case SyntaxKind.TrueKeyword:
case SyntaxKind.FalseKeyword:
expression = parseTokenNode();
}
let expression: BooleanLiteral | LiteralExpression | PrefixUnaryExpression = token() === SyntaxKind.TrueKeyword || token() === SyntaxKind.FalseKeyword
? parseTokenNode<BooleanLiteral>()
: parseLiteralLikeNode(token()) as LiteralExpression;
if (negative) {
unaryMinusExpression.operand = expression;
finishNode(unaryMinusExpression);
@ -2666,6 +2659,7 @@ namespace ts {
return parseJSDocNodeWithType(SyntaxKind.JSDocVariadicType);
case SyntaxKind.ExclamationToken:
return parseJSDocNodeWithType(SyntaxKind.JSDocNonNullableType);
case SyntaxKind.NoSubstitutionTemplateLiteral:
case SyntaxKind.StringLiteral:
case SyntaxKind.NumericLiteral:
case SyntaxKind.TrueKeyword:

2
src/compiler/types.ts
View File

@ -1049,7 +1049,7 @@ namespace ts {
export interface LiteralTypeNode extends TypeNode {
kind: SyntaxKind.LiteralType;
literal: Expression;
literal: BooleanLiteral | LiteralExpression | PrefixUnaryExpression;
}
export interface StringLiteral extends LiteralExpression {

6
tests/baselines/reference/noSubstitutionTemplateStringLiteralTypes.js Normal file
View File

@ -0,0 +1,6 @@
//// [noSubstitutionTemplateStringLiteralTypes.ts]
const x: `foo` = "foo";
//// [noSubstitutionTemplateStringLiteralTypes.js]
var x = "foo";

4
tests/baselines/reference/noSubstitutionTemplateStringLiteralTypes.symbols Normal file
View File

@ -0,0 +1,4 @@
=== tests/cases/compiler/noSubstitutionTemplateStringLiteralTypes.ts ===
const x: `foo` = "foo";
>x : Symbol(x, Decl(noSubstitutionTemplateStringLiteralTypes.ts, 0, 5))

6
tests/baselines/reference/noSubstitutionTemplateStringLiteralTypes.types Normal file
View File

@ -0,0 +1,6 @@
=== tests/cases/compiler/noSubstitutionTemplateStringLiteralTypes.ts ===
const x: `foo` = "foo";
>x : "foo"
>`foo` : "foo"
>"foo" : "foo"

1
tests/cases/compiler/noSubstitutionTemplateStringLiteralTypes.ts Normal file
View File

@ -0,0 +1 @@
const x: `foo` = "foo";