microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-22 02:35:48 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

extractMethod: Don't try to extract an ExpressionStatement consisting of a single token (#18450)

Browse Source 
* extractMethod: Don't try to extract an ExpressionStatement consisting of a single token

* Move to unit test
This commit is contained in:
Andy
2017-09-14 11:16:21 -07:00
committed by GitHub
parent 76eab54ab7
commit 6e512a495f
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/harness/unittests/extractMethods.ts
View File

@@ -410,6 +410,8 @@ function test(x: number) {
"Statement or expression expected."
]);
testExtractRangeFailed("extract-method-not-for-token-expression-statement", `[#|a|]`, ["Select more than a single token."]);
testExtractMethod("extractMethod1",
`namespace A {
let x = 1;

2
src/services/refactors/extractMethod.ts
View File

@@ -231,7 +231,7 @@ namespace ts.refactor.extractMethod {
}
function checkRootNode(node: Node): Diagnostic[] | undefined {
if (isToken(node)) {
if (isToken(isExpressionStatement(node) ? node.expression : node)) {
return [createDiagnosticForNode(node, Messages.InsufficientSelection)];
}
return undefined;