microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-06 23:59:42 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #30094 from Kingwl/improve_completions_for_optional_props

Browse Source 
check completions with assignable rather than identity
This commit is contained in:
Daniel Rosenwasser
2019-02-26 16:19:50 -08:00
committed by GitHub
parent 288851066b 4d7ec380a9
commit e8e7e88b2a
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -7406,7 +7406,7 @@ namespace ts {
const nameType = property.name && getLiteralTypeFromPropertyName(property.name);
const name = nameType && isTypeUsableAsPropertyName(nameType) ? getPropertyNameFromType(nameType) : undefined;
const expected = name === undefined ? undefined : getTypeOfPropertyOfType(contextualType, name);
return !!expected && isLiteralType(expected) && !isTypeIdenticalTo(getTypeOfNode(property), expected);
return !!expected && isLiteralType(expected) && !isTypeAssignableTo(getTypeOfNode(property), expected);
});
}

18
tests/cases/fourslash/completionsWithOptionalProperties.ts Normal file
View File

@@ -0,0 +1,18 @@
/// <reference path="fourslash.ts" />
// @strict: true
//// interface Options {
//// hello?: boolean;
//// world?: boolean;
//// }
//// declare function foo(options?: Options): void;
//// foo({
//// hello: true,
//// /**/
//// });
verify.completions({
marker: "",
includes: ['world']
});