microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-11 10:46:28 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

When tsc --build --clean, only remove tsbuildinfo if its incremental build

Browse Source
This commit is contained in:
Sheetal Nandi
2022-06-02 16:35:45 -07:00
parent 0cf9e30103
commit e4e6672609
4 changed files with 19 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/compiler/tsbuildPublic.ts
View File

@@ -2033,21 +2033,19 @@ namespace ts {
reportParseConfigFileDiagnostic(state, resolvedPath);
continue;
}
const buildInfoPath = getTsBuildInfoEmitOutputFilePath(parsed.options);
if (buildInfoPath) {
// Only delete buildInfo as thats sufficient
removeOutput(buildInfoPath, resolvedPath);
continue;
}
const outputs = getAllProjectOutputs(parsed, !host.useCaseSensitiveFileNames());
if (!outputs.length) continue;
const inputFileNames = new Set(parsed.fileNames.map(f => toPath(state, f)));
for (const output of outputs) {
// If output name is same as input file name, do not delete and ignore the error
if (inputFileNames.has(toPath(state, output))) continue;
if (host.fileExists(output)) {
if (filesToDelete) {
filesToDelete.push(output);
}
else {
host.deleteFile(output);
invalidateProject(state, resolvedPath, ConfigFileProgramReloadLevel.None);
}
}
removeOutput(output, resolvedPath);
}
}
@@ -2056,6 +2054,18 @@ namespace ts {
}
return ExitStatus.Success;
function removeOutput(output: string, resolvedPath: ResolvedConfigFilePath) {
if (host.fileExists(output)) {
if (filesToDelete) {
filesToDelete.push(output);
}
else {
host.deleteFile(output);
invalidateProject(state, resolvedPath, ConfigFileProgramReloadLevel.None);
}
}
}
}
function invalidateProject(state: SolutionBuilderState, resolved: ResolvedConfigFilePath, reloadLevel: ConfigFileProgramReloadLevel) {

12
tests/baselines/reference/tsbuild/outFile/clean-projects.js
View File

@@ -596,20 +596,8 @@ Output::
exitCode:: ExitStatus.Success
//// [/src/2/second-output.d.ts] unlink
//// [/src/2/second-output.d.ts.map] unlink
//// [/src/2/second-output.js] unlink
//// [/src/2/second-output.js.map] unlink
//// [/src/2/second-output.tsbuildinfo] unlink
//// [/src/first/bin/first-output.d.ts] unlink
//// [/src/first/bin/first-output.d.ts.map] unlink
//// [/src/first/bin/first-output.js] unlink
//// [/src/first/bin/first-output.js.map] unlink
//// [/src/first/bin/first-output.tsbuildinfo] unlink
//// [/src/third/thirdjs/output/third-output.d.ts] unlink
//// [/src/third/thirdjs/output/third-output.d.ts.map] unlink
//// [/src/third/thirdjs/output/third-output.js] unlink
//// [/src/third/thirdjs/output/third-output.js.map] unlink
//// [/src/third/thirdjs/output/third-output.tsbuildinfo] unlink

4
tests/baselines/reference/tsbuild/outFile/cleans-till-project-specified.js
View File

@@ -596,8 +596,4 @@ Output::
exitCode:: ExitStatus.Success
//// [/src/2/second-output.d.ts] unlink
//// [/src/2/second-output.d.ts.map] unlink
//// [/src/2/second-output.js] unlink
//// [/src/2/second-output.js.map] unlink
//// [/src/2/second-output.tsbuildinfo] unlink

11
tests/baselines/reference/tsbuild/sample1/removes-all-files-it-built.js
View File

@@ -390,19 +390,8 @@ Output::
exitCode:: ExitStatus.Success
//// [/src/core/anotherModule.d.ts] unlink
//// [/src/core/anotherModule.d.ts.map] unlink
//// [/src/core/anotherModule.js] unlink
//// [/src/core/index.d.ts] unlink
//// [/src/core/index.d.ts.map] unlink
//// [/src/core/index.js] unlink
//// [/src/core/tsconfig.tsbuildinfo] unlink
//// [/src/logic/index.d.ts] unlink
//// [/src/logic/index.js] unlink
//// [/src/logic/index.js.map] unlink
//// [/src/logic/tsconfig.tsbuildinfo] unlink
//// [/src/tests/index.d.ts] unlink
//// [/src/tests/index.js] unlink
//// [/src/tests/tsconfig.tsbuildinfo] unlink