microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-15 03:23:08 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

organizeImports: Fix bug in reference-testing for renamed import (#22797)

Browse Source
This commit is contained in:
Andy 2018-03-22 13:08:58 -07:00 committed by GitHub
parent 54274a8a2a
commit e0ca8a5f39
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/harness/unittests/organizeImports.ts
View File

@ -197,6 +197,16 @@ export const Other = 1;
assert.isEmpty(changes);
});
testOrganizeImports("Renamed_used",
{
path: "/test.ts",
content: `
import { F1 as EffOne, F2 as EffTwo } from "lib";
EffOne();
`,
},
libFile);
testOrganizeImports("Simple",
{
path: "/test.ts",

2
src/services/organizeImports.ts
View File

@ -98,7 +98,7 @@ namespace ts.OrganizeImports {
}
else {
// List of named imports
const newElements = namedBindings.elements.filter(e => isDeclarationUsed(e.propertyName || e.name));
const newElements = namedBindings.elements.filter(e => isDeclarationUsed(e.name));
if (newElements.length < namedBindings.elements.length) {
namedBindings = newElements.length
? updateNamedImports(namedBindings, newElements)

9
tests/baselines/reference/organizeImports/Renamed_used.ts Normal file
View File

@ -0,0 +1,9 @@
// ==ORIGINAL==
import { F1 as EffOne, F2 as EffTwo } from "lib";
EffOne();
// ==ORGANIZED==
import { F1 as EffOne } from "lib";
EffOne();