microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Do not offer completions for default module member symbol (#55231)

Browse Source
This commit is contained in:
Mateusz Burzyński 2023-08-01 23:52:40 +02:00 committed by GitHub
parent b87e301822
commit defe33afa1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@ -45463,7 +45463,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
if (meaning) {
source.forEach(symbol => {
// Similar condition as in `resolveNameHelper`
if (!getDeclarationOfKind(symbol, SyntaxKind.ExportSpecifier) && !getDeclarationOfKind(symbol, SyntaxKind.NamespaceExport)) {
if (!getDeclarationOfKind(symbol, SyntaxKind.ExportSpecifier) && !getDeclarationOfKind(symbol, SyntaxKind.NamespaceExport) && symbol.escapedName !== InternalSymbolName.Default) {
copySymbol(symbol, meaning);
}
});

16
tests/cases/fourslash/completionsDefaultKeywordWhenDefaultExportAvailable.ts Normal file
View File

@ -0,0 +1,16 @@
/// <reference path="fourslash.ts" />
// https://github.com/microsoft/TypeScript/issues/3229
// @filename: index.ts
//// export default function () {}
//// def/*1*/
verify.completions(
{
marker: "1",
includes: [{ name: "default", kind: "keyword", sortText: completion.SortText.GlobalsOrKeywords }],
},
);