From defe33afa1f3bc0d7f8dfb14f754172d84a156c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Burzy=C5=84ski?= Date: Tue, 1 Aug 2023 23:52:40 +0200 Subject: [PATCH] Do not offer completions for default module member symbol (#55231) --- src/compiler/checker.ts | 2 +- ...nsDefaultKeywordWhenDefaultExportAvailable.ts | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/completionsDefaultKeywordWhenDefaultExportAvailable.ts diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index f24cb91da63..97c272990ac 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -45463,7 +45463,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker { if (meaning) { source.forEach(symbol => { // Similar condition as in `resolveNameHelper` - if (!getDeclarationOfKind(symbol, SyntaxKind.ExportSpecifier) && !getDeclarationOfKind(symbol, SyntaxKind.NamespaceExport)) { + if (!getDeclarationOfKind(symbol, SyntaxKind.ExportSpecifier) && !getDeclarationOfKind(symbol, SyntaxKind.NamespaceExport) && symbol.escapedName !== InternalSymbolName.Default) { copySymbol(symbol, meaning); } }); diff --git a/tests/cases/fourslash/completionsDefaultKeywordWhenDefaultExportAvailable.ts b/tests/cases/fourslash/completionsDefaultKeywordWhenDefaultExportAvailable.ts new file mode 100644 index 00000000000..05bdbb8187a --- /dev/null +++ b/tests/cases/fourslash/completionsDefaultKeywordWhenDefaultExportAvailable.ts @@ -0,0 +1,16 @@ +/// + +// https://github.com/microsoft/TypeScript/issues/3229 + +// @filename: index.ts + +//// export default function () {} +//// def/*1*/ + +verify.completions( + { + marker: "1", + includes: [{ name: "default", kind: "keyword", sortText: completion.SortText.GlobalsOrKeywords }], + }, +); +