microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-10 10:32:45 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

enable go-to-type-definition on type nodes (#46714)

Browse Source 
* enable go-to-type-definition on type nodes

* only go when symbol has no value meaning

* Update formatting of src/services/goToDefinition.ts

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
This commit is contained in:
Zzzen
2021-11-19 00:55:54 +08:00
committed by GitHub
parent a75f26e68b
commit de4ba0f208
4 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/services/goToDefinition.ts
View File

@@ -198,14 +198,17 @@ namespace ts.GoToDefinition {
return undefined;
}
const symbol = typeChecker.getSymbolAtLocation(node);
const symbol = getSymbol(node, typeChecker);
if (!symbol) return undefined;
const typeAtLocation = typeChecker.getTypeOfSymbolAtLocation(symbol, node);
const returnType = tryGetReturnTypeOfFunction(symbol, typeAtLocation, typeChecker);
const fromReturnType = returnType && definitionFromType(returnType, typeChecker, node);
// If a function returns 'void' or some other type with no definition, just return the function definition.
return fromReturnType && fromReturnType.length !== 0 ? fromReturnType : definitionFromType(typeAtLocation, typeChecker, node);
const typeDefinitions = fromReturnType && fromReturnType.length !== 0 ? fromReturnType : definitionFromType(typeAtLocation, typeChecker, node);
return typeDefinitions.length ? typeDefinitions
: !(symbol.flags & SymbolFlags.Value) && symbol.flags & SymbolFlags.Type ? getDefinitionFromSymbol(typeChecker, skipAlias(symbol, typeChecker), node)
: undefined;
}
function definitionFromType(type: Type, checker: TypeChecker, node: Node): readonly DefinitionInfo[] {

6
tests/cases/fourslash/goToTypeDefinition3.ts Normal file
View File

@@ -0,0 +1,6 @@
/// <reference path='fourslash.ts' />
////type /*definition*/T = string;
////const x: /*reference*/T;
verify.goToType("reference", "definition");

12
tests/cases/fourslash/goToTypeDefinition4.ts Normal file
View File

@@ -0,0 +1,12 @@
/// <reference path='fourslash.ts' />
// @Filename: foo.ts
////export type /*def0*/T = string;
////export const /*def1*/T = "";
// @Filename: bar.ts
////import { T } from "./foo";
////let x: [|/*reference*/T|];
verify.goToType("reference", []);
verify.goToDefinition("reference", ["def0", "def1"]);

10
tests/cases/fourslash/goToTypeDefinition5.ts Normal file
View File

@@ -0,0 +1,10 @@
/// <reference path='fourslash.ts' />
// @Filename: foo.ts
////let Foo: /*definition*/unresolved;
////type Foo = { x: string };
/////*reference*/Foo;
verify.goToType("reference", []);