microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-17 01:49:41 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Don't rename static 'this' when renaming class (#22235)

Browse Source
This commit is contained in:
Andy
2018-03-02 10:23:08 -08:00
committed by GitHub
parent b90cdb2221
commit dd27288e5a
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/findAllReferences.ts
View File

@@ -1010,7 +1010,7 @@ namespace ts.FindAllReferences.Core {
function addClassStaticThisReferences(referenceLocation: Node, search: Search, state: State): void {
addReference(referenceLocation, search.symbol, state);
if (isClassLike(referenceLocation.parent)) {
if (!state.options.isForRename && isClassLike(referenceLocation.parent)) {
Debug.assert(referenceLocation.parent.name === referenceLocation);
// This is the class declaration.
addStaticThisReferences(referenceLocation.parent, state.referenceAdder(search.symbol));

4
tests/cases/fourslash/findAllRefsClassWithStaticThisAccess.ts
View File

@@ -9,4 +9,6 @@
const [r0, r1, r2] = test.ranges();
verify.referenceGroups(r0, [{ definition: "class C", ranges: [r0, r1, r2] }]);
verify.referenceGroups([r1, r2], [{ definition: "this: typeof C", ranges: [r1, r2] }]);
verify.singleReferenceGroup("this: typeof C", [r1, r2]);
verify.renameLocations(r0, [r0]);