microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-30 04:16:48 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

don't apply refactor when parameter has decorators

Browse Source
This commit is contained in:
Gabriela Araujo Britto
2019-02-11 14:24:05 -08:00
parent 4e135f13b5
commit dbd84996aa
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/services/refactors/convertToNamedParameters.ts
View File

@@ -142,7 +142,7 @@ namespace ts.refactor.convertToNamedParameters {
}
function isValidParameterDeclaration(paramDeclaration: ParameterDeclaration): paramDeclaration is ValidParameterDeclaration {
return !paramDeclaration.modifiers && isIdentifier(paramDeclaration.name);
return !paramDeclaration.modifiers && !paramDeclaration.decorators && isIdentifier(paramDeclaration.name);
}
}
@@ -361,5 +361,6 @@ namespace ts.refactor.convertToNamedParameters {
interface ValidParameterDeclaration extends ParameterDeclaration {
name: Identifier;
modifiers: undefined;
decorators: undefined;
}
}

11
tests/cases/fourslash/refactorConvertToNamedParameters30.ts Normal file
View File

@@ -0,0 +1,11 @@
/// <reference path='fourslash.ts' />
////declare function required(target: Object, propertyKey: string | symbol, parameterIndex: number)
////class C {
//// /*a*/bar/*b*/(@required a: number, b: number) {
////
//// }
////}
goTo.select("a", "b");
verify.not.refactorAvailable("Convert to named parameters");