Merge pull request #1094 from Microsoft/findAllRefsInTemplates

Corrected isExpression for templates.

src/compiler/parser.ts

@@ -491,6 +491,7 @@ module ts {
             case SyntaxKind.BinaryExpression:
             case SyntaxKind.ConditionalExpression:
             case SyntaxKind.TemplateExpression:
+            case SyntaxKind.NoSubstitutionTemplateLiteral:
             case SyntaxKind.OmittedExpression:
                 return true;
             case SyntaxKind.QualifiedName:
@@ -503,7 +504,6 @@ module ts {
             // fall through
             case SyntaxKind.NumericLiteral:
             case SyntaxKind.StringLiteral:
-            case SyntaxKind.NoSubstitutionTemplateLiteral:
                 var parent = node.parent;
                 switch (parent.kind) {
                     case SyntaxKind.VariableDeclaration:
@@ -532,6 +532,8 @@ module ts {
                             (<ForInStatement>parent).expression === node;
                     case SyntaxKind.TypeAssertion:
                         return node === (<TypeAssertion>parent).operand;
+                    case SyntaxKind.TemplateSpan:
+                        return node === (<TemplateSpan>parent).expression;
                     default:
                         if (isExpression(parent)) {
                             return true;

tests/baselines/reference/templateStringInArrowFunction.types

@@ -3,5 +3,5 @@ var x = x => `abc${ x }def`;
 >x : (x: any) => string
 >x => `abc${ x }def` : (x: any) => string
 >x : any
->x : unknown
+>x : any
 

tests/baselines/reference/templateStringInArrowFunctionES6.types

@@ -3,5 +3,5 @@ var x = x => `abc${ x }def`;
 >x : (x: any) => string
 >x => `abc${ x }def` : (x: any) => string
 >x : any
->x : unknown
+>x : any
 

tests/cases/fourslash/findAllRefsInsideTemplates1.ts

@@ -0,0 +1,12 @@
+/// <reference path='fourslash.ts'/>
+
+////var [|x|] = 10;
+////var y = `${ [|x|] } ${ [|x|] }`
+
+test.ranges().forEach(targetRange => {
+    goTo.position(targetRange.start);
+
+    test.ranges().forEach(range => {
+        verify.referencesAtPositionContains(range);
+    }
+}

tests/cases/fourslash/findAllRefsInsideTemplates2.ts

@@ -0,0 +1,12 @@
+/// <reference path='fourslash.ts'/>
+
+////function [|f|](...rest: any[]) { }
+////[|f|] `${ [|f|] } ${ [|f|] }`
+
+test.ranges().forEach(targetRange => {
+    goTo.position(targetRange.start);
+
+    test.ranges().forEach(range => {
+        verify.referencesAtPositionContains(range);
+    }
+}