microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-20 05:17:43 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix JSDoc param type completions when name hasn’t been written yet (#35787)

Browse Source
This commit is contained in:
Andrew Branch
2019-12-20 15:23:53 -06:00
committed by GitHub
parent a0d47d632d
commit d96be353cb
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/completions.ts
View File

@@ -854,7 +854,7 @@ namespace ts.Completions {
insideJsDocTagTypeExpression = isCurrentlyEditingNode(tag.typeExpression);
}
}
if (isJSDocParameterTag(tag) && (nodeIsMissing(tag.name) || tag.name.pos <= position && position <= tag.name.end)) {
if (!insideJsDocTagTypeExpression && isJSDocParameterTag(tag) && (nodeIsMissing(tag.name) || tag.name.pos <= position && position <= tag.name.end)) {
return { kind: CompletionDataKind.JsDocParameterName, tag };
}
}

18
tests/cases/fourslash/completionsJsdocParamTypeBeforeName.ts Normal file
View File

@@ -0,0 +1,18 @@
/// <reference path="fourslash.ts" />
//// /** @param /*name1*/ {/*type*/} /*name2*/ */
//// function toString(obj) {}
verify.completions({
marker: "type",
exact: completion.globalTypes
});
verify.completions({
marker: "name1",
exact: ["obj"]
});
verify.completions({
marker: "name2",
exact: ["obj"]
});