microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-10 10:58:20 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #11830 from Microsoft/jsDocAV

Browse Source 
Fix the AV resulting from presence of undefined in the jsDocPropertyTags
This commit is contained in:
Sheetal Nandi
2016-10-25 10:42:49 -07:00
committed by GitHub
parent 3bdff73c16 f98369b711
commit d54e889cf2
2 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/compiler/parser.ts
View File

@@ -6639,12 +6639,16 @@ namespace ts {
return true;
case "prop":
case "property":
if (!parentTag.jsDocPropertyTags) {
parentTag.jsDocPropertyTags = <NodeArray<JSDocPropertyTag>>[];
}
const propertyTag = parsePropertyTag(atToken, tagName);
parentTag.jsDocPropertyTags.push(propertyTag);
return true;
if (propertyTag) {
if (!parentTag.jsDocPropertyTags) {
parentTag.jsDocPropertyTags = <NodeArray<JSDocPropertyTag>>[];
}
parentTag.jsDocPropertyTags.push(propertyTag);
return true;
}
// Error parsing property tag
return false;
}
return false;
}

8
tests/cases/fourslash/incorrectJsDocObjectLiteralType.ts Normal file
View File

@@ -0,0 +1,8 @@
///<reference path="fourslash.ts" />
//// /**/
goTo.marker();
verify.navigationItemsListCount(0, "foo", "exact");
edit.insert("/**\n * @typedef {Object} foo\n * @property {any} [obj]\n */\nexport default function foo() {\n}");
verify.navigationItemsListContains("foo", "function", "foo", "exact");