fix(37825): exclude private fields from completions in subclasses (#37906)

src/services/completions.ts

@@ -2427,7 +2427,8 @@ namespace ts.Completions {
             return baseSymbols.filter(propertySymbol =>
                 !existingMemberNames.has(propertySymbol.escapedName) &&
                 !!propertySymbol.declarations &&
-                !(getDeclarationModifierFlagsFromSymbol(propertySymbol) & ModifierFlags.Private));
+                !(getDeclarationModifierFlagsFromSymbol(propertySymbol) & ModifierFlags.Private) &&
+                !isPrivateIdentifierPropertyDeclaration(propertySymbol.valueDeclaration));
         }
 
         /**

tests/cases/fourslash/completionListClassPrivateFields.ts

@@ -0,0 +1,15 @@
+/// <reference path="fourslash.ts" />
+
+////class A {
+////    #private = 1;
+////}
+////
+////class B extends A {
+////    /**/
+////}
+
+verify.completions({
+    marker: "",
+    exact: completion.classElementKeywords,
+    isNewIdentifierLocation: true
+});

tests/cases/fourslash/completionListClassPrivateFields_JS.ts

@@ -0,0 +1,21 @@
+/// <reference path="fourslash.ts" />
+
+// @allowJs: true
+// @Filename: a.js
+////class A {
+////    #private = 1;
+////}
+////
+////class B extends A {
+////    /**/
+////}
+
+verify.completions({
+    marker: "",
+    exact: [
+        { name: "A", sortText: completion.SortText.JavascriptIdentifiers },
+        { name: "B", sortText: completion.SortText.JavascriptIdentifiers },
+        ...completion.classElementInJsKeywords
+    ],
+    isNewIdentifierLocation: true
+});