microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 18:04:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Replace missingType with undefinedType in the IndexedAccessTypeNode's type (#52016)

Browse Source
This commit is contained in:
Mateusz Burzyński
2023-02-04 01:32:22 +01:00
committed by GitHub
parent c06711da1b
commit c9b5f2b022
4 changed files with 60 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/checker.ts
View File

@@ -17060,8 +17060,8 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
}
}
const propType = getTypeOfSymbol(prop);
return accessExpression && getAssignmentTargetKind(accessExpression) !== AssignmentKind.Definite ?
getFlowTypeOfReference(accessExpression, propType) :
return accessExpression && getAssignmentTargetKind(accessExpression) !== AssignmentKind.Definite ? getFlowTypeOfReference(accessExpression, propType) :
accessNode && isIndexedAccessTypeNode(accessNode) && containsMissingType(propType) ? getUnionType([propType, undefinedType]) :
propType;
}
if (everyType(objectType, isTupleType) && isNumericLiteralName(propName)) {

26
tests/baselines/reference/typePredicateAcceptingPartialOfRefinedType.symbols Normal file
View File

@@ -0,0 +1,26 @@
=== tests/cases/compiler/typePredicateAcceptingPartialOfRefinedType.ts ===
// repro #51953
interface Test {
>Test : Symbol(Test, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 0, 0))
testy?: string;
>testy : Symbol(Test.testy, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 2, 16))
}
interface Options {
>Options : Symbol(Options, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 4, 1))
test: Test['testy'];
>test : Symbol(Options.test, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 6, 19))
>Test : Symbol(Test, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 0, 0))
}
declare function includesAllRequiredOptions(options: Partial<Options>): options is Options;
>includesAllRequiredOptions : Symbol(includesAllRequiredOptions, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 8, 1))
>options : Symbol(options, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 10, 44))
>Partial : Symbol(Partial, Decl(lib.es5.d.ts, --, --))
>Options : Symbol(Options, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 4, 1))
>options : Symbol(options, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 10, 44))
>Options : Symbol(Options, Decl(typePredicateAcceptingPartialOfRefinedType.ts, 4, 1))

17
tests/baselines/reference/typePredicateAcceptingPartialOfRefinedType.types Normal file
View File

@@ -0,0 +1,17 @@
=== tests/cases/compiler/typePredicateAcceptingPartialOfRefinedType.ts ===
// repro #51953
interface Test {
testy?: string;
>testy : string | undefined
}
interface Options {
test: Test['testy'];
>test : string | undefined
}
declare function includesAllRequiredOptions(options: Partial<Options>): options is Options;
>includesAllRequiredOptions : (options: Partial<Options>) => options is Options
>options : Partial<Options>

15
tests/cases/compiler/typePredicateAcceptingPartialOfRefinedType.ts Normal file
View File

@@ -0,0 +1,15 @@
// @strict: true
// @exactOptionalPropertyTypes: true
// @noEmit: true
// repro #51953
interface Test {
testy?: string;
}
interface Options {
test: Test['testy'];
}
declare function includesAllRequiredOptions(options: Partial<Options>): options is Options;