Fix relation between generic mapped types and types with index signatures (#38761)

* Fix relation between generic mapped type and type with index signature(s) * Add tests
2026-05-12 19:31:16 -05:00 · 2020-05-25 09:55:41 -07:00
parent ba357e4a64
commit c5b8f4fcd4
5 changed files with 241 additions and 3 deletions
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -17288,9 +17288,10 @@ namespace ts {
                    return Ternary.True;
                }
                if (isGenericMappedType(source)) {
-                    // A generic mapped type { [P in K]: T } is related to an index signature { [x: string]: U }
-                    // if T is related to U.
-                    return kind === IndexKind.String ? isRelatedTo(getTemplateTypeFromMappedType(source), targetType, reportErrors) : Ternary.False;
+                    // A generic mapped type { [P in K]: T } is related to a type with an index signature
+                    // { [x: string]: U }, and optionally with an index signature { [x: number]: V },
+                    // if T is related to U and V.
+                    return getIndexTypeOfType(target, IndexKind.String) ? isRelatedTo(getTemplateTypeFromMappedType(source), targetType, reportErrors) : Ternary.False;
                }
                const indexType = getIndexTypeOfType(source, kind) || kind === IndexKind.Number && getIndexTypeOfType(source, IndexKind.String);
                if (indexType) {
--- a/tests/baselines/reference/mappedTypeAndIndexSignatureRelation.js
+++ b/tests/baselines/reference/mappedTypeAndIndexSignatureRelation.js
@@ -0,0 +1,36 @@
+//// [mappedTypeAndIndexSignatureRelation.ts]
+type Same<T> = { [P in keyof T]: T[P] };
+
+type T1<T extends Record<PropertyKey, number>> = T;
+type T2<U extends Record<PropertyKey, number>> = T1<Same<U>>;
+
+// Repro from #38235
+
+type Foo<IdentifierT extends Record<PropertyKey, PropertyKey>> =
+    IdentifierT
+;
+
+type Bar<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+    {
+        [k in keyof T] : Foo<IdentifierT & { k : k }>
+    }
+;
+
+type Merge2<T> = { [k in keyof T] : T[k] }
+type Bar2<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+    {
+        [k in keyof T]: Foo<Merge2<IdentifierT & { k: k }>>
+    }
+;
+
+type Identity<T> = T;
+type Merge3<T> = Identity<{ [k in keyof T] : T[k] }>
+type Bar3<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+    {
+        [k in keyof T]: Foo<Merge3<IdentifierT & { k: k }>>
+    }
+;
+
+
+//// [mappedTypeAndIndexSignatureRelation.js]
+"use strict";
--- a/tests/baselines/reference/mappedTypeAndIndexSignatureRelation.symbols
+++ b/tests/baselines/reference/mappedTypeAndIndexSignatureRelation.symbols
@@ -0,0 +1,117 @@
+=== tests/cases/compiler/mappedTypeAndIndexSignatureRelation.ts ===
+type Same<T> = { [P in keyof T]: T[P] };
+>Same : Symbol(Same, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 0))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 10))
+>P : Symbol(P, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 18))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 10))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 10))
+>P : Symbol(P, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 18))
+
+type T1<T extends Record<PropertyKey, number>> = T;
+>T1 : Symbol(T1, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 40))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 2, 8))
+>Record : Symbol(Record, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 2, 8))
+
+type T2<U extends Record<PropertyKey, number>> = T1<Same<U>>;
+>T2 : Symbol(T2, Decl(mappedTypeAndIndexSignatureRelation.ts, 2, 51))
+>U : Symbol(U, Decl(mappedTypeAndIndexSignatureRelation.ts, 3, 8))
+>Record : Symbol(Record, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>T1 : Symbol(T1, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 40))
+>Same : Symbol(Same, Decl(mappedTypeAndIndexSignatureRelation.ts, 0, 0))
+>U : Symbol(U, Decl(mappedTypeAndIndexSignatureRelation.ts, 3, 8))
+
+// Repro from #38235
+
+type Foo<IdentifierT extends Record<PropertyKey, PropertyKey>> =
+>Foo : Symbol(Foo, Decl(mappedTypeAndIndexSignatureRelation.ts, 3, 61))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 7, 9))
+>Record : Symbol(Record, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+
+    IdentifierT
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 7, 9))
+
+;
+
+type Bar<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+>Bar : Symbol(Bar, Decl(mappedTypeAndIndexSignatureRelation.ts, 9, 1))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 11, 9))
+>Record : Symbol(Record, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 11, 62))
+    {
+        [k in keyof T] : Foo<IdentifierT & { k : k }>
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 13, 9))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 11, 62))
+>Foo : Symbol(Foo, Decl(mappedTypeAndIndexSignatureRelation.ts, 3, 61))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 11, 9))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 13, 44))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 13, 9))
+    }
+;
+
+type Merge2<T> = { [k in keyof T] : T[k] }
+>Merge2 : Symbol(Merge2, Decl(mappedTypeAndIndexSignatureRelation.ts, 15, 1))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 17, 12))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 17, 20))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 17, 12))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 17, 12))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 17, 20))
+
+type Bar2<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+>Bar2 : Symbol(Bar2, Decl(mappedTypeAndIndexSignatureRelation.ts, 17, 42))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 18, 10))
+>Record : Symbol(Record, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 18, 63))
+    {
+        [k in keyof T]: Foo<Merge2<IdentifierT & { k: k }>>
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 20, 9))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 18, 63))
+>Foo : Symbol(Foo, Decl(mappedTypeAndIndexSignatureRelation.ts, 3, 61))
+>Merge2 : Symbol(Merge2, Decl(mappedTypeAndIndexSignatureRelation.ts, 15, 1))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 18, 10))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 20, 50))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 20, 9))
+    }
+;
+
+type Identity<T> = T;
+>Identity : Symbol(Identity, Decl(mappedTypeAndIndexSignatureRelation.ts, 22, 1))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 24, 14))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 24, 14))
+
+type Merge3<T> = Identity<{ [k in keyof T] : T[k] }>
+>Merge3 : Symbol(Merge3, Decl(mappedTypeAndIndexSignatureRelation.ts, 24, 21))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 25, 12))
+>Identity : Symbol(Identity, Decl(mappedTypeAndIndexSignatureRelation.ts, 22, 1))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 25, 29))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 25, 12))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 25, 12))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 25, 29))
+
+type Bar3<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+>Bar3 : Symbol(Bar3, Decl(mappedTypeAndIndexSignatureRelation.ts, 25, 52))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 26, 10))
+>Record : Symbol(Record, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>PropertyKey : Symbol(PropertyKey, Decl(lib.es5.d.ts, --, --))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 26, 63))
+    {
+        [k in keyof T]: Foo<Merge3<IdentifierT & { k: k }>>
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 28, 9))
+>T : Symbol(T, Decl(mappedTypeAndIndexSignatureRelation.ts, 26, 63))
+>Foo : Symbol(Foo, Decl(mappedTypeAndIndexSignatureRelation.ts, 3, 61))
+>Merge3 : Symbol(Merge3, Decl(mappedTypeAndIndexSignatureRelation.ts, 24, 21))
+>IdentifierT : Symbol(IdentifierT, Decl(mappedTypeAndIndexSignatureRelation.ts, 26, 10))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 28, 50))
+>k : Symbol(k, Decl(mappedTypeAndIndexSignatureRelation.ts, 28, 9))
+    }
+;
+
--- a/tests/baselines/reference/mappedTypeAndIndexSignatureRelation.types
+++ b/tests/baselines/reference/mappedTypeAndIndexSignatureRelation.types
@@ -0,0 +1,51 @@
+=== tests/cases/compiler/mappedTypeAndIndexSignatureRelation.ts ===
+type Same<T> = { [P in keyof T]: T[P] };
+>Same : Same<T>
+
+type T1<T extends Record<PropertyKey, number>> = T;
+>T1 : T
+
+type T2<U extends Record<PropertyKey, number>> = T1<Same<U>>;
+>T2 : Same<U>
+
+// Repro from #38235
+
+type Foo<IdentifierT extends Record<PropertyKey, PropertyKey>> =
+>Foo : IdentifierT
+
+    IdentifierT
+;
+
+type Bar<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+>Bar : Bar<IdentifierT, T>
+    {
+        [k in keyof T] : Foo<IdentifierT & { k : k }>
+>k : k
+    }
+;
+
+type Merge2<T> = { [k in keyof T] : T[k] }
+>Merge2 : Merge2<T>
+
+type Bar2<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+>Bar2 : Bar2<IdentifierT, T>
+    {
+        [k in keyof T]: Foo<Merge2<IdentifierT & { k: k }>>
+>k : k
+    }
+;
+
+type Identity<T> = T;
+>Identity : T
+
+type Merge3<T> = Identity<{ [k in keyof T] : T[k] }>
+>Merge3 : { [k in keyof T]: T[k]; }
+
+type Bar3<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+>Bar3 : Bar3<IdentifierT, T>
+    {
+        [k in keyof T]: Foo<Merge3<IdentifierT & { k: k }>>
+>k : k
+    }
+;
+
--- a/tests/cases/compiler/mappedTypeAndIndexSignatureRelation.ts
+++ b/tests/cases/compiler/mappedTypeAndIndexSignatureRelation.ts
@@ -0,0 +1,33 @@
+// @strict: true
+
+type Same<T> = { [P in keyof T]: T[P] };
+
+type T1<T extends Record<PropertyKey, number>> = T;
+type T2<U extends Record<PropertyKey, number>> = T1<Same<U>>;
+
+// Repro from #38235
+
+type Foo<IdentifierT extends Record<PropertyKey, PropertyKey>> =
+    IdentifierT
+;
+
+type Bar<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+    {
+        [k in keyof T] : Foo<IdentifierT & { k : k }>
+    }
+;
+
+type Merge2<T> = { [k in keyof T] : T[k] }
+type Bar2<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+    {
+        [k in keyof T]: Foo<Merge2<IdentifierT & { k: k }>>
+    }
+;
+
+type Identity<T> = T;
+type Merge3<T> = Identity<{ [k in keyof T] : T[k] }>
+type Bar3<IdentifierT extends Record<PropertyKey, PropertyKey>, T> =
+    {
+        [k in keyof T]: Foo<Merge3<IdentifierT & { k: k }>>
+    }
+;