microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-10 21:07:52 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Improve JSDoc @augments diagnostics (#19011)

Browse Source
This commit is contained in:
Andy
2017-10-10 11:27:53 -07:00
committed by GitHub
parent 9ccc1b4887
commit b839e17e17
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/checker.ts
View File

@@ -20034,7 +20034,7 @@ namespace ts {
function checkJSDocAugmentsTag(node: JSDocAugmentsTag): void {
const classLike = getJSDocHost(node);
if (!isClassDeclaration(classLike) && !isClassExpression(classLike)) {
error(classLike, Diagnostics.JSDoc_augments_is_not_attached_to_a_class_declaration);
error(classLike, Diagnostics.JSDoc_0_is_not_attached_to_a_class, idText(node.tagName));
return;
}
@@ -20049,7 +20049,7 @@ namespace ts {
if (extend) {
const className = getIdentifierFromEntityNameExpression(extend.expression);
if (className && name.escapedText !== className.escapedText) {
error(name, Diagnostics.JSDoc_augments_0_does_not_match_the_extends_1_clause, idText(name), idText(className));
error(name, Diagnostics.JSDoc_0_1_does_not_match_the_extends_2_clause, idText(node.tagName), idText(name), idText(className));
}
}
}

4
src/compiler/diagnosticMessages.json
View File

@@ -3519,11 +3519,11 @@
"category": "Error",
"code": 8021
},
"JSDoc '@augments' is not attached to a class declaration.": {
"JSDoc '@{0}' is not attached to a class.": {
"category": "Error",
"code": 8022
},
"JSDoc '@augments {0}' does not match the 'extends {1}' clause.": {
"JSDoc '@{0} {1}' does not match the 'extends {2}' clause.": {
"category": "Error",
"code": 8023
},

4
tests/baselines/reference/jsdocAugments_notAClass.errors.txt
View File

@@ -1,4 +1,4 @@
/b.js(3,10): error TS8022: JSDoc '@augments' is not attached to a class declaration.
/b.js(3,10): error TS8022: JSDoc '@augments' is not attached to a class.
==== /b.js (1 errors) ====
@@ -6,5 +6,5 @@
/** @augments A */
function b() {}
~
!!! error TS8022: JSDoc '@augments' is not attached to a class declaration.
!!! error TS8022: JSDoc '@augments' is not attached to a class.