microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-07-06 06:49:29 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix missing func modifier (#40379)

Browse Source 
* Fix missing function modifier

* Update src/services/refactors/convertArrowFunctionOrFunctionExpression.ts

Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>

Co-authored-by: Ron Buckton <ron.buckton@microsoft.com>
This commit is contained in:
Wenlu Wang
2021-03-11 01:34:31 +08:00
committed by GitHub
parent b1f86eca3e
commit b20331a4db
2 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/services/refactors/convertArrowFunctionOrFunctionExpression.ts
View File

@@ -208,7 +208,10 @@ namespace ts.refactor.convertArrowFunctionOrFunctionExpression {
const { variableDeclaration, variableDeclarationList, statement, name } = variableInfo;
suppressLeadingTrivia(statement);
const newNode = factory.createFunctionDeclaration(func.decorators, statement.modifiers, func.asteriskToken, name, func.typeParameters, func.parameters, func.type, body);
const modifiersFlags = (getCombinedModifierFlags(variableDeclaration) & ModifierFlags.Export) | getEffectiveModifierFlags(func);
const modifiers = factory.createModifiersFromModifierFlags(modifiersFlags);
const newNode = factory.createFunctionDeclaration(func.decorators, length(modifiers) ? modifiers : undefined, func.asteriskToken, name, func.typeParameters, func.parameters, func.type, body);
if (variableDeclarationList.declarations.length === 1) {
return textChanges.ChangeTracker.with(context, t => t.replaceNode(file, statement, newNode));

11
tests/cases/fourslash/refactorConvertArrowFunctionOrFunctionExpression_AsyncModifiers.ts Normal file
View File

@@ -0,0 +1,11 @@
/// <reference path='fourslash.ts' />
//// const /*x*/a/*y*/ = async () => { return 42; };
goTo.select("x", "y");
edit.applyRefactor({
refactorName: "Convert arrow function or function expression",
actionName: "Convert to named function",
actionDescription: "Convert to named function",
newContent: `async function a() { return 42; }`,
});