Only add suggestion for modules

This commit is contained in:
Andy Hanson
2018-04-30 10:11:52 -07:00
parent 64b595ea0e
commit b1a728fdac
5 changed files with 23 additions and 7 deletions

View File

@@ -32,7 +32,7 @@ namespace ts {
}
check(sourceFile);
if (!isJsFile) {
if (!isJsFile && sourceFile.externalModuleIndicator) {
for (const statement of sourceFile.statements) {
if (isVariableStatement(statement) &&
statement.declarationList.flags & NodeFlags.Const &&

View File

@@ -1,7 +1,8 @@
/// <reference path='fourslash.ts' />
// @Filename: /a.ts
////export {};
////const a = [|require("a")|];
////a;
verify.getSuggestionDiagnostics([{
message: "'require' call may be converted to an import.",
@@ -11,5 +12,8 @@ verify.getSuggestionDiagnostics([{
verify.codeFix({
description: "Convert 'require' to 'import'",
newFileContent:
`import a = require("a");`,
// TODO: GH#23781
`export {};
import a = require("a");
a;`,
});

View File

@@ -1,6 +1,6 @@
/// <reference path='fourslash.ts' />
// @Filename: /a.ts
////export {};
////const a = [|require("a")|];
////const b = [|require("b")|];
@@ -8,6 +8,8 @@ verify.codeFixAll({
fixId: "requireInTs",
fixAllDescription: "Convert all 'require' to 'import'",
newFileContent:
`import a = require("a");
// TODO: GH#23781
`export {};
import a = require("a");
import b = require("b");`,
});

View File

@@ -2,10 +2,15 @@
// @allowSyntheticDefaultImports: true
// @Filename: /a.ts
////export {};
////const a = [|require("a")|];
////a;
verify.codeFix({
description: "Convert 'require' to 'import'",
newFileContent: `import a from "a";`,
newFileContent:
// TODO: GH#23781
`export {};
import a from "a";
a;`,
});

View File

@@ -0,0 +1,5 @@
/// <reference path='fourslash.ts' />
////const a = [|require("a")|];
verify.getSuggestionDiagnostics([]);