microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 04:43:37 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(47782): forbid super() extraction outside this container (#47784)

Browse Source
This commit is contained in:
Oleksandr T
2022-02-07 23:26:39 +02:00
committed by GitHub
parent 14feed97a0
commit afeacf41bd
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/refactors/extractSymbol.ts
View File

@@ -486,8 +486,8 @@ namespace ts.refactor.extractSymbol {
// but a super *method call* simply implies a 'this' reference
if (node.parent.kind === SyntaxKind.CallExpression) {
// Super constructor call
const containingClass = getContainingClass(node)!; // TODO:GH#18217
if (containingClass.pos < span.start || containingClass.end >= (span.start + span.length)) {
const containingClass = getContainingClass(node);
if (containingClass === undefined || containingClass.pos < span.start || containingClass.end >= (span.start + span.length)) {
(errors ||= []).push(createDiagnosticForNode(node, Messages.cannotExtractSuper));
return true;
}

6
tests/cases/fourslash/extractSuperOutsideClass.ts Normal file
View File

@@ -0,0 +1,6 @@
/// <reference path='fourslash.ts' />
/////*a*/super()/*b*/
goTo.select("a", "b");
verify.not.refactorAvailable("Extract Symbol");