microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-06 15:03:14 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

initializer issues

Browse Source
This commit is contained in:
Arthur Ozga
2017-05-09 11:09:20 -07:00
parent 51c76ac351
commit ac68e8d6f1
1 changed files with 11 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/compiler/checker.ts
View File

@@ -2810,7 +2810,10 @@ namespace ts {
function symbolToParameterDeclaration(parameterSymbol: Symbol, context: NodeBuilderContext): ParameterDeclaration {
const parameterDeclaration = <ParameterDeclaration>getDeclarationOfKind(parameterSymbol, SyntaxKind.Parameter);
const parameterType = getTypeOfSymbol(parameterSymbol);
let parameterType = getTypeOfSymbol(parameterSymbol);
if (isRequiredInitializedParameter(parameterDeclaration)) {
parameterType = includeFalsyTypes(parameterType, TypeFlags.Undefined);
}
const parameterTypeNode = typeToTypeNodeHelper(parameterType, context);
let name: BindingName;
if (parameterDeclaration.name.kind === SyntaxKind.Identifier) {
@@ -2820,25 +2823,19 @@ namespace ts {
Debug.assert(parameterDeclaration.name.kind === SyntaxKind.ArrayBindingPattern || parameterDeclaration.name.kind === SyntaxKind.ObjectBindingPattern);
name = cloneBindingName(parameterDeclaration.name);
}
let questionToken: Token<SyntaxKind.QuestionToken> | undefined;
let initializer: Expression | undefined;
if (isOptionalParameter(parameterDeclaration)) {
questionToken = createToken(SyntaxKind.QuestionToken);
}
else {
// TODO(aozgaa): In the future, check initializer accessibility.
initializer = parameterDeclaration.initializer;
}
const questionToken = isOptionalParameter(parameterDeclaration) ? createToken(SyntaxKind.QuestionToken) : undefined;
const dotDotDotToken = (parameterDeclaration ? isRestParameter(parameterDeclaration) : isTransientSymbol(parameterSymbol) && parameterSymbol.isRestParameter) ?
createToken(SyntaxKind.DotDotDotToken) :
undefined;
const parameterNode = createParameter(
/*decorators*/ undefined,
cloneNodeArray(parameterDeclaration.modifiers),
(parameterDeclaration ? isRestParameter(parameterDeclaration) : isTransientSymbol(parameterSymbol) && parameterSymbol.isRestParameter) ?
createToken(SyntaxKind.DotDotDotToken) :
undefined,
dotDotDotToken,
name,
questionToken,
parameterTypeNode,
initializer);
/*initializer*/ undefined);
return parameterNode;
function cloneBindingName(node: BindingName): BindingName {