ignore Initial check if left of DestructuringAsignment (#20906)

This commit is contained in:
Wenlu Wang 2018-01-09 05:13:23 +08:00 committed by Mohamed Hegazy
parent 06c9a28b36
commit a82d1f8580
5 changed files with 40 additions and 1 deletions

View File

@ -13333,6 +13333,7 @@ namespace ts {
const declarationContainer = getControlFlowContainer(declaration);
let flowContainer = getControlFlowContainer(node);
const isOuterVariable = flowContainer !== declarationContainer;
const isSpreadDestructuringAsignmentTarget = node.parent && node.parent.parent && isSpreadAssignment(node.parent) && isDestructuringAssignmentTarget(node.parent.parent);
// When the control flow originates in a function expression or arrow function and we are referencing
// a const variable or parameter from an outer function, we extend the origin of the control flow
// analysis to include the immediately enclosing function.
@ -13344,7 +13345,7 @@ namespace ts {
// We only look for uninitialized variables in strict null checking mode, and only when we can analyze
// the entire control flow graph from the variable's declaration (i.e. when the flow container and
// declaration container are the same).
const assumeInitialized = isParameter || isAlias || isOuterVariable ||
const assumeInitialized = isParameter || isAlias || isOuterVariable || isSpreadDestructuringAsignmentTarget ||
type !== autoType && type !== autoArrayType && (!strictNullChecks || (type.flags & TypeFlags.Any) !== 0 ||
isInTypeQuery(node) || node.parent.kind === SyntaxKind.ExportSpecifier) ||
node.parent.kind === SyntaxKind.NonNullExpression ||

View File

@ -0,0 +1,17 @@
//// [destructuringAssignmentWithStrictNullChecks.ts]
let bar: {};
({ ...bar } = {});
//// [destructuringAssignmentWithStrictNullChecks.js]
var __rest = (this && this.__rest) || function (s, e) {
var t = {};
for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && e.indexOf(p) < 0)
t[p] = s[p];
if (s != null && typeof Object.getOwnPropertySymbols === "function")
for (var i = 0, p = Object.getOwnPropertySymbols(s); i < p.length; i++) if (e.indexOf(p[i]) < 0)
t[p[i]] = s[p[i]];
return t;
};
var bar;
(bar = __rest({}, []));

View File

@ -0,0 +1,7 @@
=== tests/cases/compiler/destructuringAssignmentWithStrictNullChecks.ts ===
let bar: {};
>bar : Symbol(bar, Decl(destructuringAssignmentWithStrictNullChecks.ts, 0, 3))
({ ...bar } = {});
>bar : Symbol(bar, Decl(destructuringAssignmentWithStrictNullChecks.ts, 0, 3))

View File

@ -0,0 +1,11 @@
=== tests/cases/compiler/destructuringAssignmentWithStrictNullChecks.ts ===
let bar: {};
>bar : {}
({ ...bar } = {});
>({ ...bar } = {}) : {}
>{ ...bar } = {} : {}
>{ ...bar } : {}
>bar : {}
>{} : {}

View File

@ -0,0 +1,3 @@
// @strictNullChecks: true
let bar: {};
({ ...bar } = {});