microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-15 12:51:30 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #8016 from Microsoft/namedImportCompletion

Browse Source 
Completion list of named imports shouldnt contain default export member
This commit is contained in:
Sheetal Nandi
2016-04-11 14:43:26 -07:00
parent b0584b58fa c2e12efc89
commit a3d35ffdf1
2 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/services.ts
View File

@@ -3834,10 +3834,10 @@ namespace ts {
}
if (isEmpty(existingImportsOrExports)) {
return exportsOfModule;
return filter(exportsOfModule, e => e.name !== "default");
}
return filter(exportsOfModule, e => !lookUp(existingImportsOrExports, e.name));
return filter(exportsOfModule, e => e.name !== "default" && !lookUp(existingImportsOrExports, e.name));
}
/**

23
tests/cases/fourslash/completionInNamedImportLocation.ts Normal file
View File

@@ -0,0 +1,23 @@
/// <reference path='fourslash.ts'/>
// @Filename: file.ts
////export var x = 10;
////export var y = 10;
////export default class C {
////}
// @Filename: a.ts
////import { /*1*/ } from "./file";
////import { x, /*2*/ } from "./file";
goTo.file("a.ts");
goTo.marker('1');
verify.completionListContains("x", "var x: number");
verify.completionListContains("y", "var y: number");
verify.not.completionListContains("C");
goTo.marker('2');
verify.not.completionListContains("x", "var x: number");
verify.completionListContains("y", "var y: number");
verify.not.completionListContains("C");