microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-06 04:35:21 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Merge pull request #15788 from Microsoft/fix15707

Browse Source 
if a JSSpecialPropertyDeclaration has a JSDoc type, use it
This commit is contained in:
Ron Buckton
2017-05-11 17:10:52 -07:00
committed by GitHub
parent 1a7c193621 3521b9c546
commit a12ec1af43
4 changed files with 75 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/compiler/checker.ts
View File

@@ -4158,6 +4158,7 @@ namespace ts {
const types: Type[] = [];
let definedInConstructor = false;
let definedInMethod = false;
let jsDocType: Type;
for (const declaration of symbol.declarations) {
const expression = declaration.kind === SyntaxKind.BinaryExpression ? <BinaryExpression>declaration :
declaration.kind === SyntaxKind.PropertyAccessExpression ? <BinaryExpression>getAncestor(declaration, SyntaxKind.BinaryExpression) :
@@ -4176,19 +4177,26 @@ namespace ts {
}
}
if (expression.flags & NodeFlags.JavaScriptFile) {
// If there is a JSDoc type, use it
const type = getTypeForDeclarationFromJSDocComment(expression.parent);
if (type && type !== unknownType) {
types.push(getWidenedType(type));
continue;
// If there is a JSDoc type, use it
const type = getTypeForDeclarationFromJSDocComment(expression.parent);
if (type) {
const declarationType = getWidenedType(type);
if (!jsDocType) {
jsDocType = declarationType;
}
else if (jsDocType !== unknownType && declarationType !== unknownType && !isTypeIdenticalTo(jsDocType, declarationType)) {
const name = getNameOfDeclaration(declaration);
error(name, Diagnostics.Subsequent_variable_declarations_must_have_the_same_type_Variable_0_must_be_of_type_1_but_here_has_type_2, declarationNameToString(name), typeToString(jsDocType), typeToString(declarationType));
}
}
types.push(getWidenedLiteralType(checkExpressionCached(expression.right)));
else if (!jsDocType) {
// If we don't have an explicit JSDoc type, get the type from the expression.
types.push(getWidenedLiteralType(checkExpressionCached(expression.right)));
}
}
return getWidenedType(addOptionality(getUnionType(types, /*subtypeReduction*/ true), definedInMethod && !definedInConstructor));
const type = jsDocType || getUnionType(types, /*subtypeReduction*/ true);
return getWidenedType(addOptionality(type, definedInMethod && !definedInConstructor));
}
// Return the type implied by a binding pattern element. This is the type of the initializer of the element if
@@ -13229,7 +13237,7 @@ namespace ts {
}
return result;
}
}
}
function isValidSpreadType(type: Type): boolean {
return !!(type.flags & (TypeFlags.Any | TypeFlags.Null | TypeFlags.Undefined | TypeFlags.NonPrimitive) ||

20
tests/baselines/reference/checkJsFiles7.symbols Normal file
View File

@@ -0,0 +1,20 @@
=== tests/cases/compiler/a.js ===
class C {
>C : Symbol(C, Decl(a.js, 0, 0))
constructor() {
/** @type {boolean} */
this.a = true;
>this.a : Symbol(C.a, Decl(a.js, 1, 16), Decl(a.js, 3, 16))
>this : Symbol(C, Decl(a.js, 0, 0))
>a : Symbol(C.a, Decl(a.js, 1, 16), Decl(a.js, 3, 16))
this.a = !!this.a;
>this.a : Symbol(C.a, Decl(a.js, 1, 16), Decl(a.js, 3, 16))
>this : Symbol(C, Decl(a.js, 0, 0))
>a : Symbol(C.a, Decl(a.js, 1, 16), Decl(a.js, 3, 16))
>this.a : Symbol(C.a, Decl(a.js, 1, 16), Decl(a.js, 3, 16))
>this : Symbol(C, Decl(a.js, 0, 0))
>a : Symbol(C.a, Decl(a.js, 1, 16), Decl(a.js, 3, 16))
}
}

25
tests/baselines/reference/checkJsFiles7.types Normal file
View File

@@ -0,0 +1,25 @@
=== tests/cases/compiler/a.js ===
class C {
>C : C
constructor() {
/** @type {boolean} */
this.a = true;
>this.a = true : true
>this.a : boolean
>this : this
>a : boolean
>true : true
this.a = !!this.a;
>this.a = !!this.a : boolean
>this.a : boolean
>this : this
>a : boolean
>!!this.a : boolean
>!this.a : boolean
>this.a : true
>this : this
>a : true
}
}

12
tests/cases/compiler/checkJsFiles7.ts Normal file
View File

@@ -0,0 +1,12 @@
// @allowJs: true
// @checkJs: true
// @noEmit: true
// @noImplicitAny: true
// @fileName: a.js
class C {
constructor() {
/** @type {boolean} */
this.a = true;
this.a = !!this.a;
}
}