microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-22 22:55:36 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Support element access aliases: exports["x"] = x (#40514)

Browse Source
This commit is contained in:
Nathan Shively-Sanders
2020-09-11 18:05:47 -07:00
committed by GitHub
parent eee799fe0c
commit 9c99870058
4 changed files with 30 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/checker.ts
View File

@@ -2408,7 +2408,7 @@ namespace ts {
|| node.kind === SyntaxKind.ExportSpecifier
|| node.kind === SyntaxKind.ExportAssignment && exportAssignmentIsAlias(<ExportAssignment>node)
|| isBinaryExpression(node) && getAssignmentDeclarationKind(node) === AssignmentDeclarationKind.ModuleExports && exportAssignmentIsAlias(node)
|| isPropertyAccessExpression(node)
|| isAccessExpression(node)
&& isBinaryExpression(node.parent)
&& node.parent.left === node
&& node.parent.operatorToken.kind === SyntaxKind.EqualsToken
@@ -2803,7 +2803,7 @@ namespace ts {
return getTargetOfAliasLikeExpression(expression, dontRecursivelyResolve);
}
function getTargetOfPropertyAccessExpression(node: PropertyAccessExpression, dontRecursivelyResolve: boolean): Symbol | undefined {
function getTargetOfAccessExpression(node: AccessExpression, dontRecursivelyResolve: boolean): Symbol | undefined {
if (!(isBinaryExpression(node.parent) && node.parent.left === node && node.parent.operatorToken.kind === SyntaxKind.EqualsToken)) {
return undefined;
}
@@ -2836,8 +2836,9 @@ namespace ts {
return resolveEntityName((node as ShorthandPropertyAssignment).name, SymbolFlags.Value | SymbolFlags.Type | SymbolFlags.Namespace, /*ignoreErrors*/ true, dontRecursivelyResolve);
case SyntaxKind.PropertyAssignment:
return getTargetOfPropertyAssignment(node as PropertyAssignment, dontRecursivelyResolve);
case SyntaxKind.ElementAccessExpression:
case SyntaxKind.PropertyAccessExpression:
return getTargetOfPropertyAccessExpression(node as PropertyAccessExpression, dontRecursivelyResolve);
return getTargetOfAccessExpression(node as AccessExpression, dontRecursivelyResolve);
default:
return Debug.fail();
}

9
tests/baselines/reference/moduleExportAliasElementAccessExpression.symbols Normal file
View File

@@ -0,0 +1,9 @@
=== tests/cases/conformance/salsa/moduleExportAliasElementAccessExpression.js ===
function D () { }
>D : Symbol(D, Decl(moduleExportAliasElementAccessExpression.js, 0, 0))
exports["D"] = D;
>exports : Symbol("tests/cases/conformance/salsa/moduleExportAliasElementAccessExpression", Decl(moduleExportAliasElementAccessExpression.js, 0, 0))
>"D" : Symbol("D", Decl(moduleExportAliasElementAccessExpression.js, 0, 17))
>D : Symbol(D, Decl(moduleExportAliasElementAccessExpression.js, 0, 0))

11
tests/baselines/reference/moduleExportAliasElementAccessExpression.types Normal file
View File

@@ -0,0 +1,11 @@
=== tests/cases/conformance/salsa/moduleExportAliasElementAccessExpression.js ===
function D () { }
>D : () => void
exports["D"] = D;
>exports["D"] = D : () => void
>exports["D"] : () => void
>exports : typeof import("tests/cases/conformance/salsa/moduleExportAliasElementAccessExpression")
>"D" : "D"
>D : () => void

6
tests/cases/conformance/salsa/moduleExportAliasElementAccessExpression.ts Normal file
View File

@@ -0,0 +1,6 @@
// @noEmit: true
// @checkJs: true
// @filename: moduleExportAliasElementAccessExpression.js
function D () { }
exports["D"] = D;