microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-16 15:51:35 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

optimize getEdits string concatenation

Browse Source
This commit is contained in:
BigAru
2018-12-07 15:41:04 +01:00
parent ad0614abea
commit 9b9aa350af
1 changed files with 9 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/services/refactors/convertStringOrTemplateLiteral.ts
View File

@@ -68,15 +68,10 @@ namespace ts.refactor.convertStringOrTemplateLiteral {
if (isTemplateExpression(node.parent) || isTemplateSpan(node.parent)) {
const templateLiteralExpression = isTemplateSpan(node.parent) ? node.parent.parent : node.parent;
const { head, templateSpans } = templateLiteralExpression;
const arrayOfNodes: Expression[] = [];
const arrayOfNodes = templateSpans.map(templateSpanToExpressions)
.reduce((accumulator, nextArray) => accumulator.concat(nextArray));
if (head.text.length !== 0) arrayOfNodes.push(createStringLiteral(head.text));
templateSpans.forEach(ts => {
arrayOfNodes.push(ts.expression);
const text = ts.literal.text;
if (text.length !== 0) arrayOfNodes.push(createStringLiteral(text));
});
if (head.text.length !== 0) arrayOfNodes.unshift(createStringLiteral(head.text));
const binaryExpression = arrayToTree(arrayOfNodes);
return textChanges.ChangeTracker.with(context, t => t.replaceNode(context.file, templateLiteralExpression, binaryExpression));
@@ -88,6 +83,12 @@ namespace ts.refactor.convertStringOrTemplateLiteral {
}
}
function templateSpanToExpressions(templateSpan: TemplateSpan): Expression[] {
const { expression, literal } = templateSpan;
const text = literal.text;
return text.length === 0 ? [expression] : [expression, createStringLiteral(text)];
}
function getParentBinaryExpression(expr: Node) {
while (isBinaryExpression(expr.parent)) {
expr = expr.parent;