microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-07-02 14:48:32 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Discard overloads with fewer parameters during signature relationship checks

Browse Source
This commit is contained in:
Ron Buckton
2017-01-11 14:26:39 -08:00
parent 5e6c5ef2f0
commit 90b1c4ab48
1 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/compiler/checker.ts
View File

@@ -7947,17 +7947,25 @@ namespace ts {
let result = Ternary.True;
const saveErrorInfo = errorInfo;
let minArgumentCountOfSource = 0;
for (const s of sourceSignatures) {
minArgumentCountOfSource = Math.max(minArgumentCountOfSource, s.minArgumentCount);
}
outer: for (const t of targetSignatures) {
// Only elaborate errors from the first failure
let shouldElaborateErrors = reportErrors;
const maximumEffectiveCallLength = Math.min(minArgumentCountOfSource, t.minArgumentCount);
for (const s of sourceSignatures) {
const related = signatureRelatedTo(s, t, shouldElaborateErrors);
if (related) {
result &= related;
errorInfo = saveErrorInfo;
continue outer;
if (s.hasRestParameter || s.minArgumentCount >= maximumEffectiveCallLength) {
const related = signatureRelatedTo(s, t, shouldElaborateErrors);
if (related) {
result &= related;
errorInfo = saveErrorInfo;
continue outer;
}
shouldElaborateErrors = false;
}
shouldElaborateErrors = false;
}
if (shouldElaborateErrors) {