CR feedback

This commit is contained in:
Ryan Cavanaugh
2015-11-10 17:17:30 -08:00
parent 1a0299d371
commit 9006b44ddf
2 changed files with 4 additions and 4 deletions

View File

@@ -7888,7 +7888,7 @@ namespace ts {
// assignable to the JSX Element Type
const callSignature = getSingleCallSignature(getTypeOfSymbol(sym));
const callReturnType = callSignature && getReturnTypeOfSignature(callSignature);
let paramType = callReturnType && callSignature && (callSignature.parameters.length === 0 ? emptyObjectType : getTypeOfSymbol(callSignature.parameters[0]));
let paramType = callReturnType && (callSignature.parameters.length === 0 ? emptyObjectType : getTypeOfSymbol(callSignature.parameters[0]));
if (callReturnType && isTypeAssignableTo(callReturnType, jsxElementType) && (paramType.flags & TypeFlags.ObjectType)) {
// Intersect in JSX.IntrinsicAttributes if it exists
const intrinsicAttributes = getJsxType(JsxNames.IntrinsicAttributes);

View File

@@ -1119,10 +1119,10 @@ namespace Harness {
// Files from tests\lib that are requested by "@libFiles"
if (options.libFiles) {
ts.forEach(options.libFiles.split(","), filename => {
const libFileName = "tests/lib/" + filename;
for (const fileName of options.libFiles.split(",")) {
const libFileName = "tests/lib/" + fileName;
includeBuiltFiles.push({ unitName: libFileName, content: normalizeLineEndings(IO.readFile(libFileName), newLine) });
});
}
}