microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-30 04:16:48 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Avoid using old node in import fix to use namespace import (#25729)

Browse Source
This commit is contained in:
Andy
2018-07-17 13:34:56 -07:00
committed by GitHub
parent a87ed5335b
commit 89f2af17f0
2 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/codefixes/importFixes.ts
View File

@@ -482,7 +482,7 @@ namespace ts.codefix {
}
function addNamespaceQualifier(changes: textChanges.ChangeTracker, sourceFile: SourceFile, { namespacePrefix, symbolToken }: FixUseNamespaceImport): void {
changes.replaceNode(sourceFile, symbolToken, createPropertyAccess(createIdentifier(namespacePrefix), symbolToken));
changes.replaceNode(sourceFile, symbolToken, createPropertyAccess(createIdentifier(namespacePrefix), createIdentifier(symbolToken.text)));
}
interface ImportsCollection {

7
tests/cases/fourslash/importNameCodeFixExistingImport2.ts
View File

@@ -1,7 +1,8 @@
/// <reference path="fourslash.ts" />
//// [|import * as ns from "./module";
//// f1/*0*/();|]
////import * as ns from "./module";
////// Comment
////f1/*0*/();
// @Filename: module.ts
//// export function f1() {}
@@ -9,8 +10,10 @@
verify.importFixAtPosition([
`import * as ns from "./module";
// Comment
ns.f1();`,
`import * as ns from "./module";
import { f1 } from "./module";
// Comment
f1();`,
]);