microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-10 21:07:52 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fixed a crash when trying to find references on NoSubstitutionTemplateLiteral with LiteralType parent (#59889)

Browse Source
This commit is contained in:
Mateusz Burzyński
2024-09-20 00:59:36 +02:00
committed by GitHub
parent 9f150e00df
commit 88809467e8
3 changed files with 31 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/compiler/utilities.ts
View File

@@ -4227,7 +4227,9 @@ export function tryGetImportFromModuleSpecifier(node: StringLiteralLike): AnyVal
case SyntaxKind.CallExpression:
return isImportCall(node.parent) || isRequireCall(node.parent, /*requireStringLiteralLikeArgument*/ false) ? node.parent as RequireOrImportCall : undefined;
case SyntaxKind.LiteralType:
Debug.assert(isStringLiteral(node));
if (!isStringLiteral(node)) {
break;
}
return tryCast(node.parent.parent, isImportTypeNode) as ValidImportTypeNode | undefined;
default:
return undefined;

23
tests/baselines/reference/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.baseline.jsonc Normal file
View File

@@ -0,0 +1,23 @@
// === findAllReferences ===
// === /tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts ===
// type Test = `[|{| isInString: true |}T|]/*FIND ALL REFS*/`;
// === Definitions ===
// === /tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts ===
// type Test = `[|T|]/*FIND ALL REFS*/`;
// === Details ===
[
{
"containerKind": "",
"containerName": "",
"kind": "var",
"name": "T",
"displayParts": [
{
"text": "`T`",
"kind": "stringLiteral"
}
]
}
]

5
tests/cases/fourslash/findAllRefsNoSubstitutionTemplateLiteralNoCrash1.ts Normal file
View File

@@ -0,0 +1,5 @@
/// <reference path='fourslash.ts' />
//// type Test = `T/*1*/`;
verify.baselineFindAllReferences('1');