microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-30 15:15:38 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Handle resolving and unknown symbols in getLiteralTypeFromPropertyName (#22406)

Browse Source
This commit is contained in:
Wesley Wigham
2018-03-08 13:35:55 -08:00
committed by GitHub
parent 17b10dc2a9
commit 87d88e2ba3
6 changed files with 96 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -8026,7 +8026,7 @@ namespace ts {
function getLiteralTypeFromPropertyName(prop: Symbol) {
const links = getSymbolLinks(getLateBoundSymbol(prop));
if (!links.nameType) {
if (links.target) {
if (links.target && links.target !== unknownSymbol && links.target !== resolvingSymbol) {
Debug.assert(links.target.escapedName === prop.escapedName || links.target.escapedName === InternalSymbolName.Computed, "Target symbol and symbol do not have the same name");
links.nameType = getLiteralTypeFromPropertyName(links.target);
}

17
tests/baselines/reference/literalTypeNameAssertionNotTriggered.errors.txt Normal file
View File

@@ -0,0 +1,17 @@
/a.ts(1,20): error TS2307: Cannot find module 'something'.
/b.ts(3,6): error TS2345: Argument of type '""' is not assignable to parameter of type '"x"'.
==== /b.ts (1 errors) ====
import a = require('./a');
declare function f<T>(obj: T, key: keyof T): void;
f(a, "");
~~
!!! error TS2345: Argument of type '""' is not assignable to parameter of type '"x"'.
==== /a.ts (1 errors) ====
import x = require("something");
~~~~~~~~~~~
!!! error TS2307: Cannot find module 'something'.
export { x };

22
tests/baselines/reference/literalTypeNameAssertionNotTriggered.js Normal file
View File

@@ -0,0 +1,22 @@
//// [tests/cases/compiler/literalTypeNameAssertionNotTriggered.ts] ////
//// [a.ts]
import x = require("something");
export { x };
//// [b.ts]
import a = require('./a');
declare function f<T>(obj: T, key: keyof T): void;
f(a, "");
//// [a.js]
"use strict";
exports.__esModule = true;
var x = require("something");
exports.x = x;
//// [b.js]
"use strict";
exports.__esModule = true;
var a = require("./a");
f(a, "");

23
tests/baselines/reference/literalTypeNameAssertionNotTriggered.symbols Normal file
View File

@@ -0,0 +1,23 @@
=== /b.ts ===
import a = require('./a');
>a : Symbol(a, Decl(b.ts, 0, 0))
declare function f<T>(obj: T, key: keyof T): void;
>f : Symbol(f, Decl(b.ts, 0, 26))
>T : Symbol(T, Decl(b.ts, 1, 19))
>obj : Symbol(obj, Decl(b.ts, 1, 22))
>T : Symbol(T, Decl(b.ts, 1, 19))
>key : Symbol(key, Decl(b.ts, 1, 29))
>T : Symbol(T, Decl(b.ts, 1, 19))
f(a, "");
>f : Symbol(f, Decl(b.ts, 0, 26))
>a : Symbol(a, Decl(b.ts, 0, 0))
=== /a.ts ===
import x = require("something");
>x : Symbol(x, Decl(a.ts, 0, 0))
export { x };
>x : Symbol(x, Decl(a.ts, 1, 8))

25
tests/baselines/reference/literalTypeNameAssertionNotTriggered.types Normal file
View File

@@ -0,0 +1,25 @@
=== /b.ts ===
import a = require('./a');
>a : typeof a
declare function f<T>(obj: T, key: keyof T): void;
>f : <T>(obj: T, key: keyof T) => void
>T : T
>obj : T
>T : T
>key : keyof T
>T : T
f(a, "");
>f(a, "") : any
>f : <T>(obj: T, key: keyof T) => void
>a : typeof a
>"" : ""
=== /a.ts ===
import x = require("something");
>x : any
export { x };
>x : any

8
tests/cases/compiler/literalTypeNameAssertionNotTriggered.ts Normal file
View File

@@ -0,0 +1,8 @@
// @Filename: /a.ts
import x = require("something");
export { x };
// @Filename: /b.ts
import a = require('./a');
declare function f<T>(obj: T, key: keyof T): void;
f(a, "");