microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 17:05:58 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fixed a false positive "await has no effect on the type" diagnostic with mixed generic union (#50833)

Browse Source
This commit is contained in:
Mateusz Burzyński
2022-10-18 23:10:03 +02:00
committed by GitHub
parent 1f8959f5dc
commit 85d405a1d7
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -37104,7 +37104,7 @@ namespace ts {
// We only need `Awaited<T>` if `T` is a type variable that has no base constraint, or the base constraint of `T` is `any`, `unknown`, `{}`, `object`,
// or is promise-like.
if (baseConstraint ?
baseConstraint.flags & TypeFlags.AnyOrUnknown || isEmptyObjectType(baseConstraint) || isThenableType(baseConstraint) :
baseConstraint.flags & TypeFlags.AnyOrUnknown || isEmptyObjectType(baseConstraint) || someType(baseConstraint, isThenableType) :
maybeTypeOfKind(type, TypeFlags.TypeVariable)) {
return true;
}

12
tests/cases/fourslash/codeFixRemoveUnnecessaryAwait_mixedUnion.ts Normal file
View File

@@ -0,0 +1,12 @@
/// <reference path="fourslash.ts" />
// @target: esnext
//// async function fn1(a: Promise<void> | void) {
//// await a;
//// }
////
//// async function fn2<T extends Promise<void> | void>(a: T) {
//// await a;
//// }
verify.getSuggestionDiagnostics([]);