microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 17:05:58 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix completions triggered on existing private identifier property access (#36191)

Browse Source
This commit is contained in:
Andrew Branch
2020-01-15 13:13:11 -08:00
committed by GitHub
parent a9cbea4259
commit 81a942e7b9
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/services/completions.ts
View File

@@ -877,7 +877,7 @@ namespace ts.Completions {
// Check if the caret is at the end of an identifier; this is a partial identifier that we want to complete: e.g. a.toS|
// Skip this partial identifier and adjust the contextToken to the token that precedes it.
if (contextToken && position <= contextToken.end && (isIdentifier(contextToken) || isKeyword(contextToken.kind))) {
if (contextToken && position <= contextToken.end && (isIdentifierOrPrivateIdentifier(contextToken) || isKeyword(contextToken.kind))) {
const start = timestamp();
contextToken = findPrecedingToken(contextToken.getFullStart(), sourceFile, /*startNode*/ undefined)!; // TODO: GH#18217
log("getCompletionData: Get previous token 2: " + (timestamp() - start));

21
tests/cases/fourslash/completionsECMAPrivateMember.ts Normal file
View File

@@ -0,0 +1,21 @@
/// <reference path="fourslash.ts" />
// @target: esnext
////class K {
//// #value: number;
////
//// foo() {
//// this.#va/**/
//// }
////}
verify.completions({
marker: "",
exact: [{
name: "#value",
insertText: undefined
}, {
name: "foo"
}]
});