microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 18:04:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Remove unused eslint-disable directives (#52987)

Browse Source
This commit is contained in:
Jake Bailey
2023-02-27 11:01:37 -08:00
committed by GitHub
parent 835fff8106
commit 6fe711f85a
13 changed files with 9 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
scripts/build/utils.mjs
View File

@@ -1,5 +1,3 @@
/* eslint-disable no-restricted-globals */
import { CancelError } from "@esfx/canceltoken";
import assert from "assert";
import chalk from "chalk";

2
src/compiler/program.ts
View File

@@ -1633,7 +1633,7 @@ export function createProgram(rootNamesOrOptions: readonly string[] | CreateProg
// `structuralIsReused`, which would be a TDZ violation if it was not set in advance to `undefined`.
let structureIsReused: StructureIsReused;
tracing?.push(tracing.Phase.Program, "tryReuseStructureFromOldProgram", {});
structureIsReused = tryReuseStructureFromOldProgram(); // eslint-disable-line prefer-const
structureIsReused = tryReuseStructureFromOldProgram();
tracing?.pop();
if (structureIsReused !== StructureIsReused.Completely) {
processingDefaultLibFiles = [];

4
src/compiler/sourcemap.ts
View File

@@ -103,7 +103,7 @@ export function createSourceMapGenerator(host: EmitHost, file: string, sourceRoo
return sourceIndex;
}
/* eslint-disable local/boolean-trivia, no-null/no-null */
/* eslint-disable no-null/no-null */
function setSourceContent(sourceIndex: number, content: string | null) {
enter();
if (content !== null) {
@@ -115,7 +115,7 @@ export function createSourceMapGenerator(host: EmitHost, file: string, sourceRoo
}
exit();
}
/* eslint-enable local/boolean-trivia, no-null/no-null */
/* eslint-enable no-null/no-null */
function addName(name: string) {
enter();

3
src/compiler/sys.ts
View File

@@ -537,7 +537,7 @@ export function getFileWatcherEventKind(oldTime: number, newTime: number) {
/** @internal */
export const ignoredPaths = ["/node_modules/.", "/.git", "/.#"];
let curSysLog: (s: string) => void = noop; // eslint-disable-line prefer-const
let curSysLog: (s: string) => void = noop;
/** @internal */
export function sysLog(s: string) {
@@ -1465,7 +1465,6 @@ export function getNodeMajorVersion(): number | undefined {
}
// TODO: GH#18217 this is used as if it's certainly defined in many places.
// eslint-disable-next-line prefer-const
export let sys: System = (() => {
// NodeJS detects "\uFEFF" at the start of the string and *replaces* it with the actual
// byte order mark from the specified encoding. Using any other byte order mark does

4
src/compiler/types.ts
View File

@@ -4723,7 +4723,7 @@ export interface Program extends ScriptReferenceHost {
*/
emit(targetSourceFile?: SourceFile, writeFile?: WriteFileCallback, cancellationToken?: CancellationToken, emitOnlyDtsFiles?: boolean, customTransformers?: CustomTransformers): EmitResult;
/** @internal */
emit(targetSourceFile?: SourceFile, writeFile?: WriteFileCallback, cancellationToken?: CancellationToken, emitOnly?: boolean | EmitOnly, customTransformers?: CustomTransformers, forceDtsEmit?: boolean): EmitResult; // eslint-disable-line @typescript-eslint/unified-signatures
emit(targetSourceFile?: SourceFile, writeFile?: WriteFileCallback, cancellationToken?: CancellationToken, emitOnly?: boolean | EmitOnly, customTransformers?: CustomTransformers, forceDtsEmit?: boolean): EmitResult;
getOptionsDiagnostics(cancellationToken?: CancellationToken): readonly Diagnostic[];
getGlobalDiagnostics(cancellationToken?: CancellationToken): readonly Diagnostic[];
@@ -5915,7 +5915,7 @@ export const enum InternalSymbolName {
* with a normal string (which is good, it cannot be misused on assignment or on usage),
* while still being comparable with a normal string via === (also good) and castable from a string.
*/
export type __String = (string & { __escapedIdentifier: void }) | (void & { __escapedIdentifier: void }) | InternalSymbolName; // eslint-disable-line @typescript-eslint/naming-convention
export type __String = (string & { __escapedIdentifier: void }) | (void & { __escapedIdentifier: void }) | InternalSymbolName;
/** ReadonlyMap where keys are `__String`s. */
export interface ReadonlyUnderscoreEscapedMap<T> extends ReadonlyMap<__String, T> {

1
src/compiler/utilities.ts
View File

@@ -7936,7 +7936,6 @@ function SourceMapSource(this: SourceMapSource, fileName: string, text: string,
this.skipTrivia = skipTrivia || (pos => pos);
}
// eslint-disable-next-line prefer-const
/** @internal */
export const objectAllocator: ObjectAllocator = {
getNodeConstructor: () => Node as any,

2
src/compiler/visitorPublic.ts
View File

@@ -601,7 +601,7 @@ export function visitEachChild<T extends Node>(node: T, visitor: Visitor, contex
*/
export function visitEachChild<T extends Node>(node: T | undefined, visitor: Visitor, context: TransformationContext, nodesVisitor?: typeof visitNodes, tokenVisitor?: Visitor): T | undefined;
/** @internal */
export function visitEachChild<T extends Node>(node: T | undefined, visitor: Visitor, context: TransformationContext, nodesVisitor?: NodesVisitor, tokenVisitor?: Visitor, nodeVisitor?: NodeVisitor): T | undefined; // eslint-disable-line @typescript-eslint/unified-signatures
export function visitEachChild<T extends Node>(node: T | undefined, visitor: Visitor, context: TransformationContext, nodesVisitor?: NodesVisitor, tokenVisitor?: Visitor, nodeVisitor?: NodeVisitor): T | undefined;
export function visitEachChild<T extends Node>(node: T | undefined, visitor: Visitor, context: TransformationContext, nodesVisitor = visitNodes, tokenVisitor?: Visitor, nodeVisitor: NodeVisitor = visitNode): T | undefined {
if (node === undefined) {
return undefined;

4
src/harness/harnessLanguageService.ts
View File

@@ -866,22 +866,18 @@ class SessionServerHost implements ts.server.ServerHost, ts.server.Logger {
}
setTimeout(callback: (...args: any[]) => void, ms: number, ...args: any[]): any {
// eslint-disable-next-line no-restricted-globals
return setTimeout(callback, ms, ...args);
}
clearTimeout(timeoutId: any): void {
// eslint-disable-next-line no-restricted-globals
clearTimeout(timeoutId);
}
setImmediate(callback: (...args: any[]) => void, _ms: number, ...args: any[]): any {
// eslint-disable-next-line no-restricted-globals
return setImmediate(callback, args);
}
clearImmediate(timeoutId: any): void {
// eslint-disable-next-line no-restricted-globals
clearImmediate(timeoutId);
}

4
src/harness/runnerbase.ts
View File

@@ -9,10 +9,8 @@ export type TestRunnerKind = CompilerTestKind | FourslashTestKind | "project" |
export type CompilerTestKind = "conformance" | "compiler";
export type FourslashTestKind = "fourslash" | "fourslash-shims" | "fourslash-shims-pp" | "fourslash-server";
/* eslint-disable prefer-const */
export let shards = 1;
export let shardId = 1;
/* eslint-enable prefer-const */
// The following have setters as while they're read here in the harness, they're only set in the runner
export function setShards(count: number) {
@@ -65,4 +63,4 @@ export abstract class RunnerBase {
fixedPath = fixedPath.replace(localHost, "");
return fixedPath;
}
}
}

3
src/services/organizeImports.ts
View File

@@ -600,8 +600,7 @@ function compareModuleSpecifiersWorker(m1: Expression | undefined, m2: Expressio
const name2 = m2 === undefined ? undefined : getExternalModuleName(m2);
return compareBooleans(name1 === undefined, name2 === undefined) ||
compareBooleans(isExternalModuleNameRelative(name1!), isExternalModuleNameRelative(name2!)) ||
// eslint-disable-next-line @typescript-eslint/no-unnecessary-type-assertion
comparer(name1!, name2!); // I don't know why eslint is wrong but this one is necessary
comparer(name1!, name2!);
}
function getModuleSpecifierExpression(declaration: AnyImportOrRequireStatement): Expression | undefined {

2
src/services/types.ts
View File

@@ -567,10 +567,8 @@ export interface LanguageService {
getSmartSelectionRange(fileName: string, position: number): SelectionRange;
/** @internal */
// eslint-disable-next-line @typescript-eslint/unified-signatures
getDefinitionAtPosition(fileName: string, position: number, searchOtherFilesOnly: false, stopAtAlias: boolean): readonly DefinitionInfo[] | undefined;
/** @internal */
// eslint-disable-next-line @typescript-eslint/unified-signatures
getDefinitionAtPosition(fileName: string, position: number, searchOtherFilesOnly: boolean, stopAtAlias: false): readonly DefinitionInfo[] | undefined;
getDefinitionAtPosition(fileName: string, position: number): readonly DefinitionInfo[] | undefined;
getDefinitionAndBoundSpan(fileName: string, position: number): DefinitionInfoAndBoundSpan | undefined;

3
src/testRunner/parallel/host.ts
View File

@@ -318,14 +318,12 @@ export function start() {
}
case "timeout": {
if (worker.timer) {
// eslint-disable-next-line no-restricted-globals
clearTimeout(worker.timer);
}
if (data.payload.duration === "reset") {
worker.timer = undefined;
}
else {
// eslint-disable-next-line no-restricted-globals
worker.timer = setTimeout(killChild, data.payload.duration, data.payload);
}
break;
@@ -649,6 +647,5 @@ export function start() {
shimNoopTestInterface(global);
}
// eslint-disable-next-line no-restricted-globals
setTimeout(() => startDelayed(perfData, totalCost), 0); // Do real startup on next tick, so all unit tests have been collected
}

2
src/testRunner/unittests/services/preProcessFile.ts
View File

@@ -350,7 +350,6 @@ describe("unittests:: services:: PreProcessFile:", () => {
});
it("Correctly returns empty importedFiles with incorrect template expression", () => {
/* eslint-disable no-template-curly-in-string */
test("const foo = `${",
/*readImportFile*/ true,
/*detectJavaScriptImports*/ true,
@@ -362,7 +361,6 @@ describe("unittests:: services:: PreProcessFile:", () => {
ambientExternalModules: undefined,
isLibFile: false
});
/* eslint-enable no-template-curly-in-string */
});
it("Correctly return ES6 exports", () => {