microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-14 19:16:17 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

For property name of binding element use binding element as preview node

Browse Source
This commit is contained in:
Sheetal Nandi 2019-05-31 11:33:36 -07:00
parent bbd2d00b35
commit 6c04a0d14e
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/services/findAllReferences.ts
View File

@ -40,15 +40,15 @@ namespace ts.FindAllReferences {
}
// TODO(shkamat)::
// JSXOpeningElement or JSXElement for tagName ?
// JSXOpeningElement or JSXElement for tagName ?
if (!node.parent || (!isDeclaration(node.parent) && !isExportAssignment(node.parent))) {
return undefined;
}
if (node.parent.name === node || // node is name of declaration, use parent
// Property name of the import export specifier use import/export specifier
isImportOrExportSpecifier(node.parent) && node.parent.propertyName === node ||
// Is assignment of export assignment
// Property name of the import export specifier or binding pattern, use parent
((isImportOrExportSpecifier(node.parent) || isBindingElement(node.parent))
&& node.parent.propertyName === node) ||
isExportAssignment(node.parent) && node.parent.expression === node) {
return getDeclarationForDeclarationSpan(node.parent);
}

7
tests/cases/fourslash/renameObjectBindingElementPropertyName01.ts
View File

@ -1,11 +1,12 @@
/// <reference path='fourslash.ts'/>
////interface I {
//// [|property1|]: number;
//// [|[|{| "declarationRangeIndex": 0 |}property1|]: number;|]
//// property2: string;
////}
////
////var foo: I;
////var { [|property1|]: prop1 } = foo;
////[|var { [|{| "declarationRangeIndex": 2 |}property1|]: prop1 } = foo;|]
verify.rangesAreRenameLocations();
verify.rangesAreRenameLocations(test.rangesByText().get("property1"));