microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-03-05 17:23:21 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Add fast path exits if we are retaining all configured projects (#59689)

Browse Source
This commit is contained in:
Sheetal Nandi 2024-08-20 10:18:12 -07:00 committed by GitHub
parent 2192336dfe
commit 627fbcbd69
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/server/editorServices.ts
View File

@ -4456,7 +4456,7 @@ export class ProjectService {
toRetainConfiguredProjects: Set<ConfiguredProject> | undefined,
openFilesWithRetainedConfiguredProject: Set<Path> | undefined,
externalProjectsRetainingConfiguredProjects: Set<string> | undefined,
) {
): Set<ConfiguredProject> {
const toRemoveConfiguredProjects = new Set(this.configuredProjects.values());
const markOriginalProjectsAsUsed = (project: Project) => {
if (project.originalConfiguredProjects && (isConfiguredProject(project) || !project.isOrphan())) {
@ -4469,6 +4469,8 @@ export class ProjectService {
}
};
toRetainConfiguredProjects?.forEach(retainConfiguredProject);
// Everything needs to be retained, fast path to skip all the work
if (!toRemoveConfiguredProjects.size) return toRemoveConfiguredProjects;
// Do not remove configured projects that are used as original projects of other
this.inferredProjects.forEach(markOriginalProjectsAsUsed);
@ -4479,7 +4481,10 @@ export class ProjectService {
projects.forEach(retainConfiguredProject);
}
});
this.openFiles.forEach((_projectRootPath, path) => {
// Everything needs to be retained, fast path to skip all the work
if (!toRemoveConfiguredProjects.size) return toRemoveConfiguredProjects;
forEachEntry(this.openFiles, (_projectRootPath, path) => {
if (openFilesWithRetainedConfiguredProject?.has(path)) return;
const info = this.getScriptInfoForPath(path)!;
// Part of external project
@ -4491,15 +4496,21 @@ export class ProjectService {
);
if (result?.defaultProject) {
result?.seenProjects.forEach(retainConfiguredProject);
// Everything needs to be retained, fast path to skip all the work
if (!toRemoveConfiguredProjects.size) return toRemoveConfiguredProjects;
}
});
// Everything needs to be retained, fast path to skip all the work
if (!toRemoveConfiguredProjects.size) return toRemoveConfiguredProjects;
// Retain all the configured projects that have pending updates
// or the ones that is referencing retained project (or to be retained)
this.configuredProjects.forEach(project => {
forEachEntry(this.configuredProjects, project => {
if (toRemoveConfiguredProjects.has(project)) {
if (isPendingUpdate(project) || forEachReferencedProject(project, isRetained)) {
retainConfiguredProject(project);
if (!toRemoveConfiguredProjects.size) return toRemoveConfiguredProjects;
}
}
});