microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-05 08:11:30 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Reject auto-imports of relative paths through node_modules in bundler resolution (#52536)

Browse Source
This commit is contained in:
Andrew Branch 2023-01-31 13:02:59 -08:00 committed by GitHub
parent c93f20bcf8
commit 60edd0685f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/utilities.ts
View File

@ -2413,7 +2413,9 @@ export function getModuleSpecifierResolverHost(program: Program, host: LanguageS
/** @internal */
export function moduleResolutionUsesNodeModules(moduleResolution: ModuleResolutionKind): boolean {
return moduleResolution === ModuleResolutionKind.Node10 || moduleResolution >= ModuleResolutionKind.Node16 && moduleResolution <= ModuleResolutionKind.NodeNext;
return moduleResolution === ModuleResolutionKind.Node10
|| moduleResolution >= ModuleResolutionKind.Node16 && moduleResolution <= ModuleResolutionKind.NodeNext
|| moduleResolution === ModuleResolutionKind.Bundler;
}
/** @internal */

26
tests/cases/fourslash/autoImportBundlerBlockRelativeNodeModulesPaths.ts Normal file
View File

@ -0,0 +1,26 @@
/// <reference path="fourslash.ts" />
// @module: esnext
// @moduleResolution: bundler
// @Filename: /node_modules/dep/package.json
//// {
//// "name": "dep",
//// "version": "1.0.0",
//// "exports": "./dist/index.js"
//// }
// @Filename: /node_modules/dep/dist/utils.d.ts
//// export const util: () => void;
// @Filename: /node_modules/dep/dist/index.d.ts
//// export * from "./utils";
// @Filename: /index.ts
//// util/**/
// Ensures we filter out the relative path through node_modules
// for the non-reexport source, which can only be accessed
// directly with the relative path since it's blocked by the
// package.json "exports" field.
verify.importFixModuleSpecifiers("", ["dep"]);