microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 18:04:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

fix(50075): do not strip undefined from the function class properties (#50169)

Browse Source
This commit is contained in:
Oleksandr T
2022-08-19 19:34:42 +03:00
committed by GitHub
parent 05d7d6bb12
commit 5969ae9ef7
5 changed files with 136 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/checker.ts
View File

@@ -8154,7 +8154,7 @@ namespace ts {
factory.createModifiersFromModifierFlags((isReadonlySymbol(p) ? ModifierFlags.Readonly : 0) | flag),
name,
p.flags & SymbolFlags.Optional ? factory.createToken(SyntaxKind.QuestionToken) : undefined,
isPrivate ? undefined : serializeTypeForDeclaration(context, getTypeOfSymbol(p), p, enclosingDeclaration, includePrivateSymbol, bundled),
isPrivate ? undefined : serializeTypeForDeclaration(context, getWriteTypeOfSymbol(p), p, enclosingDeclaration, includePrivateSymbol, bundled),
// TODO: https://github.com/microsoft/TypeScript/pull/32372#discussion_r328386357
// interface members can't have initializers, however class members _can_
/*initializer*/ undefined

47
tests/baselines/reference/jsdocFunctionClassPropertiesDeclaration.js Normal file
View File

@@ -0,0 +1,47 @@
//// [a.js]
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
export function Foo(x, y) {
if (!(this instanceof Foo)) {
return new Foo(x, y);
}
this.x = x;
this.y = y;
}
//// [a.js]
"use strict";
exports.__esModule = true;
exports.Foo = void 0;
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
function Foo(x, y) {
if (!(this instanceof Foo)) {
return new Foo(x, y);
}
this.x = x;
this.y = y;
}
exports.Foo = Foo;
//// [a.d.ts]
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
export function Foo(x: number | undefined, y: number | undefined): Foo;
export class Foo {
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
constructor(x: number | undefined, y: number | undefined);
x: number | undefined;
y: number | undefined;
}

32
tests/baselines/reference/jsdocFunctionClassPropertiesDeclaration.symbols Normal file
View File

@@ -0,0 +1,32 @@
=== /a.js ===
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
export function Foo(x, y) {
>Foo : Symbol(Foo, Decl(a.js, 0, 0))
>x : Symbol(x, Decl(a.js, 4, 20))
>y : Symbol(y, Decl(a.js, 4, 22))
if (!(this instanceof Foo)) {
>this : Symbol(Foo, Decl(a.js, 0, 0))
>Foo : Symbol(Foo, Decl(a.js, 0, 0))
return new Foo(x, y);
>Foo : Symbol(Foo, Decl(a.js, 0, 0))
>x : Symbol(x, Decl(a.js, 4, 20))
>y : Symbol(y, Decl(a.js, 4, 22))
}
this.x = x;
>this.x : Symbol(Foo.x, Decl(a.js, 7, 5))
>this : Symbol(Foo, Decl(a.js, 0, 0))
>x : Symbol(Foo.x, Decl(a.js, 7, 5))
>x : Symbol(x, Decl(a.js, 4, 20))
this.y = y;
>this.y : Symbol(Foo.y, Decl(a.js, 8, 15))
>this : Symbol(Foo, Decl(a.js, 0, 0))
>y : Symbol(Foo.y, Decl(a.js, 8, 15))
>y : Symbol(y, Decl(a.js, 4, 22))
}

38
tests/baselines/reference/jsdocFunctionClassPropertiesDeclaration.types Normal file
View File

@@ -0,0 +1,38 @@
=== /a.js ===
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
export function Foo(x, y) {
>Foo : typeof Foo
>x : number | undefined
>y : number | undefined
if (!(this instanceof Foo)) {
>!(this instanceof Foo) : boolean
>(this instanceof Foo) : boolean
>this instanceof Foo : boolean
>this : this
>Foo : typeof Foo
return new Foo(x, y);
>new Foo(x, y) : Foo
>Foo : typeof Foo
>x : number | undefined
>y : number | undefined
}
this.x = x;
>this.x = x : number | undefined
>this.x : any
>this : this
>x : any
>x : number | undefined
this.y = y;
>this.y = y : number | undefined
>this.y : any
>this : this
>y : any
>y : number | undefined
}

18
tests/cases/compiler/jsdocFunctionClassPropertiesDeclaration.ts Normal file
View File

@@ -0,0 +1,18 @@
// @allowJs: true
// @checkJs: true
// @strict: true
// @declaration: true
// @outDir: ./out
// @filename: /a.js
/**
* @param {number | undefined} x
* @param {number | undefined} y
*/
export function Foo(x, y) {
if (!(this instanceof Foo)) {
return new Foo(x, y);
}
this.x = x;
this.y = y;
}