microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-10 18:04:18 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix goto implementation does not suggest all subtypes (#33652)

Browse Source
This commit is contained in:
Zixiang Li
2020-04-03 00:57:48 +08:00
committed by GitHub
parent 3810c2fe6b
commit 54b0e4acc5
2 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/services/findAllReferences.ts
View File

@@ -216,7 +216,32 @@ namespace ts.FindAllReferences {
export function getImplementationsAtPosition(program: Program, cancellationToken: CancellationToken, sourceFiles: readonly SourceFile[], sourceFile: SourceFile, position: number): ImplementationLocation[] | undefined {
const node = getTouchingPropertyName(sourceFile, position);
const referenceEntries = getImplementationReferenceEntries(program, cancellationToken, sourceFiles, node, position);
let referenceEntries: Entry[] | undefined;
const entries = getImplementationReferenceEntries(program, cancellationToken, sourceFiles, node, position);
if (
node.parent.kind === SyntaxKind.PropertyAccessExpression
|| node.parent.kind === SyntaxKind.BindingElement
|| node.parent.kind === SyntaxKind.ElementAccessExpression
|| node.kind === SyntaxKind.SuperKeyword
) {
referenceEntries = entries && [...entries];
}
else {
const queue = entries && [...entries];
const seenNodes = createMap<true>();
while (queue && queue.length) {
const entry = queue.shift() as NodeEntry;
if (!addToSeen(seenNodes, getNodeId(entry.node))) {
continue;
}
referenceEntries = append(referenceEntries, entry);
const entries = getImplementationReferenceEntries(program, cancellationToken, sourceFiles, entry.node, entry.node.pos);
if (entries) {
queue.push(...entries);
}
}
}
const checker = program.getTypeChecker();
return map(referenceEntries, entry => toImplementationLocation(entry, checker));
}

4
tests/cases/fourslash/goToImplementationInterface_01.ts
View File

@@ -10,10 +10,10 @@
//// abstract hello (): void;
//// }
////
//// class Bar extends SuperBar {
//// class [|Bar|] extends SuperBar {
//// }
////
//// class NotAbstractBar extends AbstractBar {
//// class [|NotAbstractBar|] extends AbstractBar {
//// hello () {}
//// }
////