microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-07-06 15:24:36 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

feat(48231): allow unique symbol for constant variables (#48270)

Browse Source
This commit is contained in:
Oleksandr T
2022-03-17 02:00:27 +02:00
committed by GitHub
parent cf8ed8fec1
commit 546a87fa31
5 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/checker.ts
View File

@@ -43992,13 +43992,11 @@ namespace ts {
if (node.type.kind !== SyntaxKind.SymbolKeyword) {
return grammarErrorOnNode(node.type, Diagnostics._0_expected, tokenToString(SyntaxKind.SymbolKeyword));
}
let parent = walkUpParenthesizedTypes(node.parent);
if (isInJSFile(parent) && isJSDocTypeExpression(parent)) {
parent = parent.parent;
if (isJSDocTypeTag(parent)) {
// walk up past JSDoc comment node
parent = parent.parent.parent;
const host = getJSDocHost(parent);
if (host) {
parent = getSingleVariableOfVariableStatement(host) || host;
}
}
switch (parent.kind) {

7
tests/baselines/reference/uniqueSymbolsDeclarationsInJs.js
View File

@@ -23,6 +23,9 @@ class C {
readonlyCall = Symbol();
readwriteCall = Symbol();
}
/** @type {unique symbol} */
const a = Symbol();
//// [uniqueSymbolsDeclarationsInJs-out.js]
@@ -46,6 +49,8 @@ class C {
static { this.readonlyStaticTypeAndCall = Symbol(); }
static { this.readwriteStaticCall = Symbol(); }
}
/** @type {unique symbol} */
const a = Symbol();
//// [uniqueSymbolsDeclarationsInJs-out.d.ts]
@@ -71,3 +76,5 @@ declare class C {
readonly readonlyCall: symbol;
readwriteCall: symbol;
}
/** @type {unique symbol} */
declare const a: unique symbol;

5
tests/baselines/reference/uniqueSymbolsDeclarationsInJs.symbols
View File

@@ -41,3 +41,8 @@ class C {
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2019.symbol.d.ts, --, --))
}
/** @type {unique symbol} */
const a = Symbol();
>a : Symbol(a, Decl(uniqueSymbolsDeclarationsInJs.js, 26, 5))
>Symbol : Symbol(Symbol, Decl(lib.es5.d.ts, --, --), Decl(lib.es2015.symbol.d.ts, --, --), Decl(lib.es2015.symbol.wellknown.d.ts, --, --), Decl(lib.es2019.symbol.d.ts, --, --))

6
tests/baselines/reference/uniqueSymbolsDeclarationsInJs.types
View File

@@ -46,3 +46,9 @@ class C {
>Symbol : SymbolConstructor
}
/** @type {unique symbol} */
const a = Symbol();
>a : symbol
>Symbol() : unique symbol
>Symbol : SymbolConstructor

3
tests/cases/conformance/types/uniqueSymbol/uniqueSymbolsDeclarationsInJs.ts
View File

@@ -31,3 +31,6 @@ class C {
readonlyCall = Symbol();
readwriteCall = Symbol();
}
/** @type {unique symbol} */
const a = Symbol();