microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-10 01:43:59 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

CR feedback

Browse Source
This commit is contained in:
Paul van Brenk
2015-04-30 17:13:26 -07:00
parent 63f3bafed6
commit 45591c846c
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/services/services.ts
View File

@@ -2981,14 +2981,16 @@ module ts {
|| containingNodeKind === SyntaxKind.ArrayLiteralExpression // [a, |
|| containingNodeKind === SyntaxKind.BinaryExpression; // let x = (a, |
case SyntaxKind.OpenParenToken:
return containingNodeKind === SyntaxKind.CallExpression // func( |
|| containingNodeKind === SyntaxKind.Constructor // constructor( |
|| containingNodeKind === SyntaxKind.NewExpression // new C(a|
|| containingNodeKind === SyntaxKind.ParenthesizedExpression // let x = (a|
|| containingNodeKind === SyntaxKind.ParenthesizedType // function F(pred: (a|
|| containingNodeKind === SyntaxKind.Parameter; // function F(pred: a|
|| containingNodeKind == SyntaxKind.FunctionType; // function F(pred: (a| // todo: figure out why fourslash and the IDE don't agree on node kind here
case SyntaxKind.ColonToken:
return containingNodeKind === SyntaxKind.Parameter; // function F(pred: a|
case SyntaxKind.OpenBracketToken:
return containingNodeKind === SyntaxKind.ArrayLiteralExpression; // [ |
@@ -3013,9 +3015,6 @@ module ts {
case SyntaxKind.TemplateMiddle:
return containingNodeKind === SyntaxKind.TemplateSpan; // `aa ${10} dd ${|
case SyntaxKind.ColonToken:
return containingNodeKind === SyntaxKind.BindingElement; // var {x :html|
case SyntaxKind.PublicKeyword:
case SyntaxKind.PrivateKeyword:
case SyntaxKind.ProtectedKeyword:
@@ -3107,10 +3106,13 @@ module ts {
containingNodeKind === SyntaxKind.ObjectBindingPattern; // function func({ x, y|
case SyntaxKind.DotToken:
return containingNodeKind === SyntaxKind.ArrayBindingPattern; // var [.|
return containingNodeKind === SyntaxKind.ArrayBindingPattern; // var [.|
case SyntaxKind.ColonToken:
return containingNodeKind === SyntaxKind.BindingElement; // var {x :html|
case SyntaxKind.OpenBracketToken:
return containingNodeKind === SyntaxKind.ArrayBindingPattern; // var [x|
return containingNodeKind === SyntaxKind.ArrayBindingPattern; // var [x|
case SyntaxKind.OpenParenToken:
return containingNodeKind === SyntaxKind.CatchClause ||

2
tests/cases/fourslash/completionListNewIdentifierBindingElement.ts
View File

@@ -3,4 +3,4 @@
////var { x:html/*1*/
goTo.marker("1");
verify.completionListAllowsNewIdentifier();
verify.completionListIsEmpty();

1
tests/cases/fourslash/completionListNewIdentifierFunctionDeclaration.ts
View File

@@ -3,7 +3,6 @@
////function F(pref: (a/*1*/
////
////function F(pref: a/*2*/
////
test.markers().forEach((m) => {
goTo.position(m.position, m.fileName);