microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-16 15:45:27 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Fix empty object literal property access

Browse Source
This commit is contained in:
Henry Mercer
2017-08-19 00:01:14 +01:00
parent 345622d22d
commit 424e84c112
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/compiler/factory.ts
View File

@@ -3811,14 +3811,18 @@ namespace ts {
*/
export function parenthesizeForAccess(expression: Expression): LeftHandSideExpression {
// isLeftHandSideExpression is almost the correct criterion for when it is not necessary
// to parenthesize the expression before a dot. The known exception is:
// to parenthesize the expression before a dot. There are two known exceptions:
//
// NewExpression:
// new C.x -> not the same as (new C).x
//
// EmptyObjectLiteral:
// {}.toString() -> is incorrect syntax, should be ({}).x
//
const emittedExpression = skipPartiallyEmittedExpressions(expression);
if (isLeftHandSideExpression(emittedExpression)
&& (emittedExpression.kind !== SyntaxKind.NewExpression || (<NewExpression>emittedExpression).arguments)) {
&& (emittedExpression.kind !== SyntaxKind.NewExpression || (<NewExpression>emittedExpression).arguments)
&& !isEmptyObjectLiteral(emittedExpression)) {
return <LeftHandSideExpression>expression;
}