microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-09 07:55:10 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Addressed quick feedback items

Browse Source
This commit is contained in:
Josh Goldberg
2019-04-03 08:32:51 -04:00
parent 38e1856945
commit 3c8ce9b316
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/compiler/checker.ts
View File

@@ -1119,7 +1119,8 @@ namespace ts {
return !findAncestor(usage, n => isComputedPropertyName(n) && n.parent.parent === declaration);
}
else if (isPropertyDeclaration(declaration)) {
return isPropertyImmediatelyReferencedWithinDeclaration(declaration, usage);
// still might be illegal if a self-referencing property initializer (eg private x = this.x)
return !isPropertyImmediatelyReferencedWithinDeclaration(declaration, usage);
}
return true;
}
@@ -1199,7 +1200,7 @@ namespace ts {
function isPropertyImmediatelyReferencedWithinDeclaration(declaration: PropertyDeclaration, usage: Node) {
// always legal if usage is after declaration
if (usage.end > declaration.end) {
return true;
return false;
}
// still might be legal if usage is deferred (e.g. x: any = () => this.x)
@@ -1227,7 +1228,7 @@ namespace ts {
}
});
return ancestorChangingReferenceScope !== undefined;
return ancestorChangingReferenceScope === undefined;
}
}