microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-06-11 10:46:28 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Test parameter initialisation narrowing rules

Browse Source
This commit is contained in:
Nathan Shively-Sanders
2016-12-21 14:58:44 -08:00
parent 6543048097
commit 3b1309d53f
4 changed files with 130 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

37
tests/baselines/reference/defaultParameterAddsUndefinedWithStrictNullChecks.js
View File

@@ -20,12 +20,27 @@ function foo3(x = "string", b: number) {
x.length; // ok, should be narrowed to string
}
// .d.ts should have `T | undefined` for foo1, foo2, foo3
foo1(undefined, 1);
foo2(undefined, 1);
foo3(undefined, 1);
// .d.ts should have `T | undefined` for foo1, foo2, foo3
function removeUndefinedButNotFalse(x = true) {
if (x === false) {
return x;
}
}
declare const cond: boolean;
function removeNothing(y = cond ? true : undefined) {
if (y !== undefined) {
if (y === false) {
return y;
}
}
return true;
}
//// [defaultParameterAddsUndefinedWithStrictNullChecks.js]
@@ -51,10 +66,25 @@ function foo3(x, b) {
if (x === void 0) { x = "string"; }
x.length; // ok, should be narrowed to string
}
// .d.ts should have `T | undefined` for foo1, foo2, foo3
foo1(undefined, 1);
foo2(undefined, 1);
foo3(undefined, 1);
// .d.ts should have `T | undefined` for foo1, foo2, foo3
function removeUndefinedButNotFalse(x) {
if (x === void 0) { x = true; }
if (x === false) {
return x;
}
}
function removeNothing(y) {
if (y === void 0) { y = cond ? true : undefined; }
if (y !== undefined) {
if (y === false) {
return y;
}
}
return true;
}
//// [defaultParameterAddsUndefinedWithStrictNullChecks.d.ts]
@@ -64,3 +94,6 @@ declare let total: number;
declare function foo1(x: string | undefined, b: number): void;
declare function foo2(x: string | undefined, b: number): void;
declare function foo3(x: string | undefined, b: number): void;
declare function removeUndefinedButNotFalse(x?: boolean | undefined): false | undefined;
declare const cond: boolean;
declare function removeNothing(y?: boolean | undefined): boolean;

36
tests/baselines/reference/defaultParameterAddsUndefinedWithStrictNullChecks.symbols
View File

@@ -68,6 +68,7 @@ function foo3(x = "string", b: number) {
>length : Symbol(String.length, Decl(lib.d.ts, --, --))
}
// .d.ts should have `T | undefined` for foo1, foo2, foo3
foo1(undefined, 1);
>foo1 : Symbol(foo1, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 7, 36))
>undefined : Symbol(undefined)
@@ -81,5 +82,38 @@ foo3(undefined, 1);
>undefined : Symbol(undefined)
// .d.ts should have `T | undefined` for foo1, foo2, foo3
function removeUndefinedButNotFalse(x = true) {
>removeUndefinedButNotFalse : Symbol(removeUndefinedButNotFalse, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 24, 19))
>x : Symbol(x, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 27, 36))
if (x === false) {
>x : Symbol(x, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 27, 36))
return x;
>x : Symbol(x, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 27, 36))
}
}
declare const cond: boolean;
>cond : Symbol(cond, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 33, 13))
function removeNothing(y = cond ? true : undefined) {
>removeNothing : Symbol(removeNothing, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 33, 28))
>y : Symbol(y, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 34, 23))
>cond : Symbol(cond, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 33, 13))
>undefined : Symbol(undefined)
if (y !== undefined) {
>y : Symbol(y, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 34, 23))
>undefined : Symbol(undefined)
if (y === false) {
>y : Symbol(y, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 34, 23))
return y;
>y : Symbol(y, Decl(defaultParameterAddsUndefinedWithStrictNullChecks.ts, 34, 23))
}
}
return true;
}

45
tests/baselines/reference/defaultParameterAddsUndefinedWithStrictNullChecks.types
View File

@@ -96,6 +96,7 @@ function foo3(x = "string", b: number) {
>length : number
}
// .d.ts should have `T | undefined` for foo1, foo2, foo3
foo1(undefined, 1);
>foo1(undefined, 1) : void
>foo1 : (x: string | undefined, b: number) => void
@@ -115,5 +116,47 @@ foo3(undefined, 1);
>1 : 1
// .d.ts should have `T | undefined` for foo1, foo2, foo3
function removeUndefinedButNotFalse(x = true) {
>removeUndefinedButNotFalse : (x?: boolean | undefined) => false | undefined
>x : boolean | undefined
>true : true
if (x === false) {
>x === false : boolean
>x : boolean
>false : false
return x;
>x : false
}
}
declare const cond: boolean;
>cond : boolean
function removeNothing(y = cond ? true : undefined) {
>removeNothing : (y?: boolean | undefined) => boolean
>y : boolean | undefined
>cond ? true : undefined : true | undefined
>cond : boolean
>true : true
>undefined : undefined
if (y !== undefined) {
>y !== undefined : boolean
>y : boolean | undefined
>undefined : undefined
if (y === false) {
>y === false : boolean
>y : boolean
>false : false
return y;
>y : false
}
}
return true;
>true : true
}

17
tests/cases/compiler/defaultParameterAddsUndefinedWithStrictNullChecks.ts
View File

@@ -21,9 +21,24 @@ function foo3(x = "string", b: number) {
x.length; // ok, should be narrowed to string
}
// .d.ts should have `T | undefined` for foo1, foo2, foo3
foo1(undefined, 1);
foo2(undefined, 1);
foo3(undefined, 1);
// .d.ts should have `T | undefined` for foo1, foo2, foo3
function removeUndefinedButNotFalse(x = true) {
if (x === false) {
return x;
}
}
declare const cond: boolean;
function removeNothing(y = cond ? true : undefined) {
if (y !== undefined) {
if (y === false) {
return y;
}
}
return true;
}