microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-16 05:58:32 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Nerf Extends to implements For Now

Browse Source
This commit is contained in:
Arthur Ozga 2016-10-27 16:33:33 -07:00
parent 5d9a4e3054
commit 3ac9ffa75e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/services/codefixes/fixExtendsInterfaceBecomesImplements.ts
View File

@ -13,20 +13,22 @@ namespace ts.codefix {
// If there is already an implements keyword, we currently have incorrect behavior.
// For now, we suppress the quickfix altogether.
/*
// TODO: (arozga) Fix this.
if(ts.forEach(children, child => child.kind === SyntaxKind.ImplementsKeyword)) {
return undefined;
}
*/
ts.forEach(children, child => {
if (child.kind === SyntaxKind.ExtendsKeyword) {
// TODO: (arozga) why is there a space before implements
// Note: child.pos points to the space *before* `extends`.
textChanges.push({ newText: " implements", span: { start: child.pos, length: child.end - child.pos } });
}
});
}
// TODO: (arozga) Get Separate messages for
// 1) Change extends to implements
// 2) Move interface to extends clause
if (textChanges.length > 0) {
return [{
description: getLocaleSpecificMessage(Diagnostics.Change_extends_to_implements),