[WIP] fix typo, make response mandatory

This commit is contained in:
Vladimir Matveev 2016-06-08 16:48:14 -07:00
parent 8c33c15bc6
commit 38b5eed062
2 changed files with 9 additions and 5 deletions

View File

@ -1530,7 +1530,7 @@ namespace ts.server {
openExternalProject(proj: protocol.ExternalProject): void {
const externalProject = this.findExternalProjectByProjectFileName(proj.projectFileName);
if (proj) {
if (externalProject) {
this.updateVersionedProjectWorker(externalProject, proj.rootFiles, proj.options);
}
else {

View File

@ -1043,17 +1043,20 @@ namespace ts.server {
private handlers: Map<(request: protocol.Request) => { response?: any, responseRequired?: boolean }> = {
[CommandNames.OpenExternalProject]: (request: protocol.OpenExternalProjectRequest) => {
this.projectService.openExternalProject(request.arguments);
return this.notRequired();
// TODO: report errors
return this.requiredResponse(true);
},
[CommandNames.OpenExternalProjects]: (request: protocol.OpenExternalProjectsRequest) => {
for (const proj of request.arguments.projects) {
this.projectService.openExternalProject(proj);
}
return this.notRequired();
// TODO: report errors
return this.requiredResponse(true);
},
[CommandNames.CloseExternalProject]: (request: protocol.CloseExternalProjectRequest) => {
this.projectService.closeExternalProject(request.arguments.projectFileName);
return this.notRequired();
// TODO: report errors
return this.requiredResponse(true);
},
[CommandNames.SynchronizeProjectList]: (request: protocol.SynchronizeProjectListRequest) => {
const result = this.projectService.synchronizeProjectList(request.arguments.knownProjects);
@ -1061,7 +1064,8 @@ namespace ts.server {
},
[CommandNames.ApplyChangedToOpenFiles]: (request: protocol.ApplyChangedToOpenFilesRequest) => {
this.projectService.applyChangesInOpenFiles(request.arguments.openFiles, request.arguments.closedFiles);
return this.notRequired();
// TODO: report errors
return this.requiredResponse(true);
},
[CommandNames.Exit]: () => {
this.exit();