diff --git a/src/server/editorServices.ts b/src/server/editorServices.ts index f1fbd6a581f..2817196c136 100644 --- a/src/server/editorServices.ts +++ b/src/server/editorServices.ts @@ -1530,7 +1530,7 @@ namespace ts.server { openExternalProject(proj: protocol.ExternalProject): void { const externalProject = this.findExternalProjectByProjectFileName(proj.projectFileName); - if (proj) { + if (externalProject) { this.updateVersionedProjectWorker(externalProject, proj.rootFiles, proj.options); } else { diff --git a/src/server/session.ts b/src/server/session.ts index 2f9982a6a57..5c148fac25a 100644 --- a/src/server/session.ts +++ b/src/server/session.ts @@ -1043,17 +1043,20 @@ namespace ts.server { private handlers: Map<(request: protocol.Request) => { response?: any, responseRequired?: boolean }> = { [CommandNames.OpenExternalProject]: (request: protocol.OpenExternalProjectRequest) => { this.projectService.openExternalProject(request.arguments); - return this.notRequired(); + // TODO: report errors + return this.requiredResponse(true); }, [CommandNames.OpenExternalProjects]: (request: protocol.OpenExternalProjectsRequest) => { for (const proj of request.arguments.projects) { this.projectService.openExternalProject(proj); } - return this.notRequired(); + // TODO: report errors + return this.requiredResponse(true); }, [CommandNames.CloseExternalProject]: (request: protocol.CloseExternalProjectRequest) => { this.projectService.closeExternalProject(request.arguments.projectFileName); - return this.notRequired(); + // TODO: report errors + return this.requiredResponse(true); }, [CommandNames.SynchronizeProjectList]: (request: protocol.SynchronizeProjectListRequest) => { const result = this.projectService.synchronizeProjectList(request.arguments.knownProjects); @@ -1061,7 +1064,8 @@ namespace ts.server { }, [CommandNames.ApplyChangedToOpenFiles]: (request: protocol.ApplyChangedToOpenFilesRequest) => { this.projectService.applyChangesInOpenFiles(request.arguments.openFiles, request.arguments.closedFiles); - return this.notRequired(); + // TODO: report errors + return this.requiredResponse(true); }, [CommandNames.Exit]: () => { this.exit();