microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-04-17 01:49:41 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

feat(49786): show completions in expression with type arguments (#49810)

Browse Source
This commit is contained in:
Oleksandr T
2022-07-19 00:55:15 +03:00
committed by GitHub
parent 91f7cfc501
commit 3863cc4a20
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/stringCompletions.ts
View File

@@ -167,9 +167,9 @@ namespace ts.Completions.StringCompletions {
case SyntaxKind.LiteralType: {
const grandParent = walkUpParentheses(parent.parent);
switch (grandParent.kind) {
case SyntaxKind.ExpressionWithTypeArguments:
case SyntaxKind.TypeReference: {
const typeReference = grandParent as TypeReferenceNode;
const typeArgument = findAncestor(parent, n => n.parent === typeReference) as LiteralTypeNode;
const typeArgument = findAncestor(parent, n => n.parent === grandParent) as LiteralTypeNode;
if (typeArgument) {
return { kind: StringLiteralCompletionKind.Types, types: getStringLiteralTypes(typeChecker.getTypeArgumentConstraint(typeArgument)), isNewIdentifier: false };
}

11
tests/cases/fourslash/completionsAtTypeArguments.ts Normal file
View File

@@ -0,0 +1,11 @@
/// <reference path="fourslash.ts" />
////interface I {
//// a: string;
//// b: number;
////}
////type T1 = Pick<I, "/*1*/">;
////interface T2 extends Pick<I, "/*2*/"> {}
verify.completions({ marker: ["1", "2"], exact: ["a", "b"] });