microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-02-06 02:33:53 -06:00
Code Issues Packages Projects Releases 212 Wiki Activity

Remove crashing diagnostic code that wasn't helping us (#36913)

Browse Source
This commit is contained in:
Ryan Cavanaugh 2020-02-27 12:45:28 -08:00 committed by GitHub
parent d33fb87da8
commit 35aea8bbfa
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/services/importTracker.ts
View File

@ -518,10 +518,6 @@ namespace ts.FindAllReferences {
}
const sym = useLhsSymbol ? checker.getSymbolAtLocation(getNameOfAccessExpression(cast(node.left, isAccessExpression))) : symbol;
// Better detection for GH#20803
if (sym && !(checker.getMergedSymbol(sym.parent!).flags & SymbolFlags.Module)) {
Debug.fail(`Special property assignment kind does not have a module as its parent. Assignment is ${Debug.formatSymbol(sym)}, parent is ${Debug.formatSymbol(sym.parent!)}`);
}
return sym && exportInfo(sym, kind);
}
}

10
tests/cases/fourslash/emptyExportFindReferences.ts Normal file
View File

@ -0,0 +1,10 @@
/// <reference path="fourslash.ts" />
// @allowNonTsExtensions: true
// @Filename: Foo.js
//// /**/module.exports = {
////
//// }
goTo.marker();
verify.occurrencesAtPositionCount(1);