microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2026-05-23 07:07:09 -05:00
Code Issues Packages Projects Releases 212 Wiki Activity

Address code review: do not emit default constructor

Browse Source
This commit is contained in:
Yui T
2015-03-15 12:33:29 -07:00
parent 13e55ae8cb
commit 2a07d3f8db
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/compiler/emitter.ts
View File

@@ -4578,15 +4578,29 @@ module ts {
tempParameters = undefined;
var popFrame = enterNameScope();
// Check if we have property assignment inside class declaration.
// If there is property assignment, we need to emit constructor whether users define it or not
// If there is no property assignment, we can omit constructor if users do not define it
var hasPropertyAssignment = false;
// Emit the constructor overload pinned comments
forEach(node.members, member => {
if (member.kind === SyntaxKind.Constructor && !(<ConstructorDeclaration>member).body) {
emitPinnedOrTripleSlashComments(member);
}
if (member.kind === SyntaxKind.PropertyDeclaration && (<PropertyDeclaration>member).initializer) {
hasPropertyAssignment = true;
}
});
var ctor = getFirstConstructorWithBody(node);
// For target ES6 and above, if there is no user-defined constructor and there is no property assignment
// do not emit constructor in class declaration.
if (languageVersion >= ScriptTarget.ES6 && !ctor && !hasPropertyAssignment) {
return;
}
if (ctor) {
emitLeadingComments(ctor);
}
@@ -4617,6 +4631,7 @@ module ts {
}
}
}
write(" {");
scopeEmitStart(node, "constructor");
increaseIndent();